Comments (8)
That's the exception thrown right now:
> size-limit
ERROR Error:
ERROR in ./lib/Core-DnMX9gqv.css
Module parse failed: /Users/Sebastian/Workspace/sebastian-software/edge-core/lib/Core-DnMX9gqv.css Unexpected token (14:0)
You may need an appropriate loader to handle this file type.
| */
|
| ::before,
| ::after {
| background-repeat: no-repeat; /* 1 */
@ ./lib/browser.es5.esm.js 13:0-44
@ multi ./lib/browser.es5.esm.js
at runWebpack.then.stats (/Users/Sebastian/Workspace/sebastian-software/edge-core/node_modules/size-limit/index.js:110:15)
at <anonymous>
from size-limit.
Why we should not bundle them? They affects to bundle size and developers should take care.
Totally agree that it should not throw error. Let's add config for css-loader
. Do you want to make PR?
from size-limit.
Both is okay in my opinion. If size-limit is mainly about JS size then it should respect JS only.
I mean right now you basically exclude asset files as well, as file-loader is replacing them with URLs.
I am not sure what is the right approach here.
If you like to have CSS included in the bundle, I'll do that PR.
from size-limit.
Are you sure, that file-loader replaces then to URL? I thought url-loader does it.
from size-limit.
It's the other way around.
"The url-loader works like the file-loader, but can return a DataURL if the file is smaller than a byte limit." via https://github.com/webpack-contrib/url-loader
from size-limit.
I am not sure about assets being added to the size. Sometimes you e.g. offer alternative file formats e.g. woff and woff2. I figure most people would never inline all of them.
from size-limit.
Here we go: #15
from size-limit.
Released in 0.10
from size-limit.
Related Issues (20)
- size-limit fails with rxjs imports
- Add customisation for improving performance culture HOT 6
- Loosen strictness of peer dependency requirement of `tslib` HOT 1
- Global installation with plugin support HOT 5
- React should be peer dependency HOT 7
- The comment might be misleading when size limit fails HOT 5
- Unable to run on windows 10 HOT 4
- Receive ERR_UNSUPPORTED_ESM_URL_SCHEME error on version 10 HOT 5
- Switch from GZIP to Brotli by default HOT 4
- plugins are `import`ed with `require.resolve` which will resolve `commonjs` entry for dual package HOT 4
- Allow customize error message HOT 1
- Inaccurate bundle size when using dynamic imports HOT 10
- Support `.size-limit.mjs` config file HOT 2
- Migrate codebase to TypeScript HOT 4
- Esbuild plugin produces incorrect numbers when CSS used HOT 7
- Extra blank lines when using --silent HOT 1
- CLI does not work with workspaces and yarn pnp or pnpm without hoisting HOT 4
- Can the config option be supported like eslint or stylelint to specify the path of the configuration file? HOT 1
- size-limit fails to detect paths/files containing unescaped characters HOT 1
- no-install, no-config options HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from size-limit.