Comments (12)
Sad news, Size Limit works good on AppVeyor https://ci.appveyor.com/project/ai/size-limit
from size-limit.
What actually confuses me is that it worked in the last iteration. Maybe it's an appveyor specific issue.
See the log:
https://ci.appveyor.com/project/swernerx/edge-core/build/108/job/5me5g2tkg7nmvyh0
from size-limit.
I think we should run Size Limit tests on AppVeyor too. Wait for a second, I create the project there.
from size-limit.
Are you sure, that it is not from prepublish
command?
from size-limit.
I released 0.8.3 with better error messages. Could you test again with it?
from size-limit.
Still seems to be broken for me. Node v6 only BTW: https://travis-ci.org/sebastian-software/edge-core/jobs/263067471
from size-limit.
That's probably a difference :) You are currently only testing on v8.
from size-limit.
Still good on Node.js 6 too https://ci.appveyor.com/project/ai/size-limit
from size-limit.
BTW, I think I found what it is the problem. It is not related with Windows.
When somebody will build your project with Webpack, it will not have fs
because of fs
available only in Node.js, not in the browser. So you must add this lines to your package.json
:
from size-limit.
Thanks for the hint with the "browser" config. Actually it should never hit this as there are two different output scenarios for the library "web" and "node". These are the entries in the package.json
:
"main": "lib/node.es5.cjs.js",
"module": "lib/node.es5.esm.js",
"browser": "lib/browser.es5.esm.js",
Which entry is size-limit
using? Because the "browser" entry point is not accessing any fs
at all.
from size-limit.
Size Limit take file from size-limit
section and pack it with webpack. As result because of this section:
{
"path": "lib/node.es5.esm.js",
"limit": "1000 KB"
}
It will take lib/node.es5.esm.js
and will try to pack it in webpack and will have issue (because packing is impossible).
In your case there is no big sense to test lib/node.es5.esm.js
size, since it doesnโt go to browser and size is not critical.
from size-limit.
That's the issue. You are absolutely right. Thanks!
from size-limit.
Related Issues (20)
- Should I ignore some file types?
- size-limit fails with rxjs imports
- Add customisation for improving performance culture HOT 6
- Loosen strictness of peer dependency requirement of `tslib` HOT 1
- Global installation with plugin support HOT 5
- React should be peer dependency HOT 7
- The comment might be misleading when size limit fails HOT 5
- Unable to run on windows 10 HOT 4
- Receive ERR_UNSUPPORTED_ESM_URL_SCHEME error on version 10 HOT 5
- Switch from GZIP to Brotli by default HOT 4
- plugins are `import`ed with `require.resolve` which will resolve `commonjs` entry for dual package HOT 4
- Allow customize error message HOT 1
- Inaccurate bundle size when using dynamic imports HOT 10
- Support `.size-limit.mjs` config file HOT 2
- Migrate codebase to TypeScript HOT 4
- Esbuild plugin produces incorrect numbers when CSS used HOT 7
- Extra blank lines when using --silent HOT 1
- CLI does not work with workspaces and yarn pnp or pnpm without hoisting HOT 4
- Can the config option be supported like eslint or stylelint to specify the path of the configuration file? HOT 1
- size-limit fails to detect paths/files containing unescaped characters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from size-limit.