Noise when recording voice in Safari browser about audio-recorder-polyfill HOT 13 CLOSED

Hi @MarinescuEvghenii I was using hark and when I checked its source indeed it was using createMediaStreamSource so what I did was to create a clone of existing stream using stream.clone() and pass it to hark, then the recording was clear. Thank you for pointing towards that. I never would have thought that createMediaStreamSource would be the reason.

@ai I think if the MediaRecorder object uses cloned stream as the stream source instead of the original stream, no matter what other scripts do with the original stream, the recording won't break.

from audio-recorder-polyfill.

Hello @harwee I didn't solve it completely but I found where is the problem in my case. Besides recording I'm drawing the animation using "AudioContext" and the problem occurs when I'm creating the media stream source:

const mediaStream = audioContext.createMediaStreamSource(stream);
mediaStream.connect(audioAnalyser);

For the moment I'm doing some fake animation in Safari.

from audio-recorder-polyfill.

Have no idea, sorry.

from audio-recorder-polyfill.

@MarinescuEvghenii were you able to solve this problem? I am facing the same.

from audio-recorder-polyfill.

@harwee interesting. Can you make PR?

from audio-recorder-polyfill.

Sure, actual change is not that big but it will break many test cases so I need to modify test cases too.

from audio-recorder-polyfill.

I can confirm that stream.clone() fixes this on Safari

from audio-recorder-polyfill.

@nicolocarpignoli do you want to send PR if you already changed the sources?

from audio-recorder-polyfill.

@ai can you make a pull request, I tried making one but since i am not a JS developer I coudn't write test cases for this change 😞

from audio-recorder-polyfill.

@harwee you can send PR without tests (it is OK for browser compatibility fixes)

from audio-recorder-polyfill.

@ai check the pull request #23

from audio-recorder-polyfill.

Can somebody test master, that problem was solved?

Just put it to package.json:

  "audio-recorder-polyfill": "ai/audio-recorder-polyfill",

from audio-recorder-polyfill.

the fix released in 0.1.4

from audio-recorder-polyfill.