Normalization of NaN is not working as intended about pyjedai HOT 2 CLOSED

I also wonder if it is necessary and good practice to convert the dataframe to string, as then there is no distinction between na and empty string anymore ...

from pyjedai.

Hello, and I'm sorry for the late reply.

Yeah you're right on your remarks. Indeed NaN handling has no effect this way. So changing rows I think will do the trick.

        # Fill NaN values with empty string
        self.dataset_1.fillna("", inplace=True)
        self.dataset_1 = self.dataset_1.astype(str)
        if not self.is_dirty_er:
            self.dataset_2.fillna("", inplace=True)
            self.dataset_2 = self.dataset_2.astype(str)

As far as the str transformation, it is necessary in order to assure that no other types will be handled. It caused issues in many other steps, and that's why we decided to handle it this way.

The above fix will be uploaded in the next release.

Thank you that you shared it with us!

Konstantinos

from pyjedai.