Add more tabs about librey HOT 8 CLOSED

I was just yesterday talking about adding Pinterest-frontend Binternet as a tab. Maps could be useful indeed, but a little hard to add, address detection seems a little hard and honestly out of the scope of LibreY. However, if there's a good PR, - that keeps privacy in mind - I will probably merge it.

from librey.

It might be possible to add maps via OSM, even if it is just a redirect to OSM's search results for that page. I'm not sure if there is any reasonable way to proxy OSM requests via libreY without using javascript to display a map. However, it might be possible to just use their API to get search results for the entered address, which link to the corresponding OSM page for that location.

As for shopping and news, I'm not sure how useful these actually are to implement: one can easily get news results by searching general so it might not be necessary to implement this.

from librey.

I checked it, seems possible indeed, but maybe a little clumsy to add a maps button for "wood plank" if someone searches for that? I'm not going to regex a bunch of cities...

from librey.

Maybe we can offload that sort of work elsewhere: for example we could do a preliminary search on OSM, and if it yeilds no street names / corresponding addresses, then we can omit this from the tabs list. However this could be an extra request that would slow down the load time to the page, and potentially lead to further ratelimits elsewhere, so might not be such a good idea.
I think adding it to the end of the list wouldnt be too distracting, as if someone did search "wood plank" they probably wouldnt think to search on maps anyway, unless it was indeed something they wanted a location for (?).

from librey.

Hmm, might be nice to implement then, shouldn't be too hard... I'll look at it!

from librey.

Closing as Maps has been added.

from librey.

Reopening as the results do not match the search criteria

When I click the first result (which is the one I am after),

it redirects me to the following link
https://www.openstreetmap.org/node/185058198

Opening this page, zooming out a bit to check where is it, it turns out to be somewhere else, in this case, somewhere in Canada instead of Melbourne/Australia

Even the street name shown is not related to Major Road

It is not only with this address, it is for all, and I have checked with a friend of mine on his locally hosted version. Same thing

from librey.

It is not only with this address, it is for all, and I have checked with a friend of mine on his locally hosted version.

This is because for street names in particular, OpenStreetMap uses /way/ to prefix their URLs, than the regular /node/. This is why it gives you a different place. Including for cities, which use /relation/ and also partially mess up the search.

The fix for this would be to use osm_type for the URL path. I'm willing to implement this.

from librey.