Git Product home page Git Product logo

Comments (7)

jotapee avatar jotapee commented on July 19, 2024 1

I have the very same issue, is there any update regarding this?

I have tried with <a>, <span>, <button>, everything. When you click on something (within the sliding panel) the panel closes itself. I don't understand what's the point of specifying a class or id on exit_selector if any link will close the panel.

Thanks in advance for any news regarding this.

from sliiide.

justrealmilk avatar justrealmilk commented on July 19, 2024 1

+1

One of these maybe
$toggle.click(handleToggle);
$sliiider.find('a').on('click', function() {deactivate();});
$exit.on('click', function() {deactivate();});

from sliiide.

justrealmilk avatar justrealmilk commented on July 19, 2024

$("a:not(.sliiider-toggle, .slider-exit)").off('click');

Thought of a solution that doesn't require editing the library. I placed it after the slider init code.

from sliiide.

justrealmilk avatar justrealmilk commented on July 19, 2024

No idea how to GitHub, but I forked this repo and fixed it myself. :-)

from sliiide.

ahmedrad avatar ahmedrad commented on July 19, 2024

It should just be the line mentioned by @justrealmilk $sliiider.find('a').on('click', function() {deactivate();});

I dunno why when you use span or button tags it still closes, can you send me an example @jotapee ?

It's a good point though I should make it an option instead.

from sliiide.

jotapee avatar jotapee commented on July 19, 2024

HI @ahmedrad I can create a fiddle for you, np, but its super easy to recreate. Simply include any link within the sliiide panel and it will close when you click on it. Also happens with span and button.
Thanks @justrealmilk for you help, I will try your script to see how it goes.
Best!

from sliiide.

ahmedrad avatar ahmedrad commented on July 19, 2024

the latest release now has an auto_close option @jotapee @DeNelo @justrealmilk .. sorry for the delay. Closing this issue

from sliiide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.