Commit feature for persistant job stores about apscheduler HOT 9 CLOSED

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

Fixed shelve store losing data on an unclean shutdown (fixes #47)

from apscheduler.

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

Interesting observation. I should modify the shelve store to do just that.

from apscheduler.

Original comment by Josh Harrison (Bitbucket: hijakk, GitHub: hijakk):

Good call. The following changed method in apscheduler/jobstores/shelve_store.py makes the jobs persist properly in my testing.

#!python

def add_job(self, job):
    job.id = self._generate_id()
    self.store[job.id] = job.__getstate__()
    self.store.close()
    self.store = shelve.open(self.path, 'c', self.pickle_protocol)
    self.jobs.append(job)

from apscheduler.

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

Would you mind doing an experiment for me?
Modify the ShelveJobStore code to close and reopen the shelve where it currently just sync()s. See if that makes a difference.

from apscheduler.

Original comment by Josh Harrison (Bitbucket: hijakk, GitHub: hijakk):

I'm probably doing something wrong, then - like I was saying, when I write
a job to that store and don't either close the jobstore explicitly, shut
down the scheduler, thereby shutting down the jobstore, the job doesn't
persist.

from apscheduler.

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

I'm not sure what difference that would make, since syncing is always done after write operations.

from apscheduler.

Original comment by Josh Harrison (Bitbucket: hijakk, GitHub: hijakk):

Not needed

from apscheduler.

Original comment by Josh Harrison (Bitbucket: hijakk, GitHub: hijakk):

Interesting - ok, what I was encountering was that if I added a job and cherrypy restarted, without closing and reopening the store, that job didn't show up anymore.
I see that I can get to the store directly and force a manual sync with sched._jobstores["shelve"].store.sync(), I'll give that a shot. Thanks!

from apscheduler.

Original comment by Alex Grönholm (Bitbucket: agronholm, GitHub: agronholm):

ShelveJobStore already does sync() on all write operations. Not sure what more you want from a commit operation.
ShelveJobStore is a toy, mostly suitable for development.
I wouldn't recommend its use it in production.

from apscheduler.