Git Product home page Git Product logo

Comments (2)

sgotti avatar sgotti commented on June 14, 2024
  • Please better explain in the issue description that you're going to create two tables in notification service.

  • Why are you saving the webhook delivery status in webhook when you already have also a webhookdelivery?

    • Additionally if you're going to give the ability to (re)deliver the webhook multiple time it doesn't makes sense for the webhook to have a delivered status.

from agola.

alessandro-sorint avatar alessandro-sorint commented on June 14, 2024
  • Please better explain in the issue description that you're going to create two tables in notification service.

  • Why are you saving the webhook delivery status in webhook when you already have also a webhookdelivery?

    • Additionally if you're going to give the ability to (re)deliver the webhook multiple time it doesn't makes sense for the webhook to have a delivered status.
  • I updated the description
  • my idea about the webhook delivery status(table RunWebhookDelivery) is to undertand if the delivery is completed(well or wrong)
  • Delivered(table RunWebhook) is set true when the delivery status is done correctly. If false the retry logic can create a new delivery and try to resend the webhook

from agola.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.