Comments (3)
great suggestion from @krauszraphael
from asyncvoter-api.
I think this issue needs to be decomposed into various features.
For example, every controller function has a next parameter. We should either be a) handling the error in the controller; or b) passing it to the next method handle the error. By default, I believe we should be doing b. if (err) return next(err)
(At least for the time being.)
Another example, we specify in Cucumber that a "sad path" returns an error. We should be going over the routes and defining what the return error codes (and for that matter success codes) writing the tests and implementing them.
from asyncvoter-api.
Additionally, if an error occurs on a certain API REST path, what HTTP error codes should we be returning and when.
from asyncvoter-api.
Related Issues (20)
- Refactor tests HOT 3
- Only active stories may be voted on
- Set environment variables across platforms
- issues with start vote feature HOT 1
- document the API HOT 2
- Specify required mongodb version
- Lock down the versions of a package's dependencies
- need CORS support for react interface
- Render new story when new issue is submitted HOT 1
- Secure master branch
- add source of story HOT 1
- add user ids to stories and votes
- create an api client
- EPIC create client code to work with api HOT 2
- deploying asyncvoter-api to azure/dokku HOT 1
- set up staging server
- allow user to update vote HOT 1
- prefer MONGO_URL to MONGODB
- Add Revealed field to API Story
- Update spec tests to test new revealed flag in story
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asyncvoter-api.