Git Product home page Git Product logo

Comments (8)

eb8680 avatar eb8680 commented on August 17, 2024

@ae-foster are there any broken standalone examples that you wanted to deprecate?

from pyro.

ae-foster avatar ae-foster commented on August 17, 2024

The main one is ab_test.py: it is using old vi_ape which I would deprecate as an EIG estimator. It's also using the BO toolbox- I'm not sure what the state of development is on that. As I remember it, the BO toolbox worked but was a bit flakey. Also sequential_oed_sigmoid_lm can be deprecated in favour of turk_experiment (they're not the same, but they are similar enough that we don't need both examples).

Wouldn't call that exhaustive- we'll probably have more things to brush up or remove as we progress.

from pyro.

ae-foster avatar ae-foster commented on August 17, 2024

The big sequential experiments from the paper are: turk_experiment (simulation version for pyro examples I assume) and location. It might be useful to start tuning these up for merge.

from pyro.

ae-foster avatar ae-foster commented on August 17, 2024

Oh and we should deprecate nonlinear_regression- that's experimental code that never made it into the paper

from pyro.

null-a avatar null-a commented on August 17, 2024

Updating this issue with relevant info from #17: once PR #25 is merged item_response, turk_experiment, and location will run (on the update-oed-pytorch branch) without error. (Though the last 2 of those depend on file system state.) Results differ from those seen on oed-master, which I think is explained by changes in PyTorch.

I'm not sure what else I can usefully contribute here. I'm still happy to try to help out, but I'm struggling to find concrete tasks to perform given that I'm not super familiar with the project. (I could e.g. fix the linter errors, but I'd rather do that once any cruft is removed and what's left is runnable.) Feel free to point me at things if I can help, but don't worry if not.

from pyro.

ae-foster avatar ae-foster commented on August 17, 2024

Thanks @null-a - I've merged the necessary fixes

from pyro.

ae-foster avatar ae-foster commented on August 17, 2024

We should start by introducing some very basic examples in examples.contrib.oed that show a user how to begin optimizing designs.

from pyro.

ae-foster avatar ae-foster commented on August 17, 2024

We can close this issue when we merge pyro-ppl#2041

from pyro.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.