Comments (4)
I was unable to reproduce using transitions with "Don't Keep Activities" enabled. But I've done as you sugested, can you validade with 1.0.0-beta05?
About the key, for that to work the key
function must be a property. Since Screen
is an interface it can't set the value itself, so every screen would have to do something like override val key = generatedUniqueKey()
. This can be avoided by change the Screen
to an abstract class, but I don't wan't to do that.
I'll keep looking for options, maybe KSP could help. Feel free to open a new issue about that. And if you have any suggestion will be very welcome :)
from voyager.
Fixed in 1.0.0-beta04. Updated the docs with instructions.
Thanks again @Grouen !
from voyager.
@adrielcafe Still doesn't work when use transitions. Default CurrentScreen() works fine. I think issue is here:
Box(modifier) {
items.forEach {
key(it.screen) {
navigator.stateHolder.SaveableStateProvider(it.screen.key) {
it.content()
}
}
}
}
Voyager should use it.screen.key instead of it.screen for key.
By The Way, maybe default key implementation should be unique? Something like View.generateViewId()
from voyager.
I was unable to reproduce using transitions with "Don't Keep Activities" enabled. But I've done as you sugested, can you validade with 1.0.0-beta05?
Issue is fixed, thanks.
from voyager.
Related Issues (20)
- Backpress in Screen HOT 1
- How to use BackHandler in a Screen with TabNavigator?
- Add windowInsets to BottomSheet HOT 1
- Working with lifecycle events in common HOT 5
- Crash due to Parcelable encountered IOException writing serializable HOT 6
- Navigator inside Dialog doesn't push screen properly
- iOS build error HOT 4
- iOS-like swipe back navigation HOT 3
- Deeplinks and Voyager HOT 1
- Voyager hilt support broken with Dagger 2.51 HOT 1
- UI Testing HOT 1
- Choose Different Animation Transitions Based on Different Screens HOT 1
- navigator scoped for viewmodel (moko-mvvm) HOT 1
- [Question] How to navigate from ScreenModel/ViewModel? HOT 1
- Window inset imePadding stopped working in 1.1.0-alpha03 HOT 2
- Voyager Screen with a `ViewModel` does not have its `SavedStateHandle` saved on process death HOT 1
- Custom back handling depending on the currentScreen HOT 2
- Integration with KMMViewModel
- Nesting Navigators prevents WindowInsets from being updated upon device rotation on iOS
- Parcelable encountered IOException writing serializable object HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from voyager.