Git Product home page Git Product logo

Comments (4)

adrielcafe avatar adrielcafe commented on May 18, 2024 2

I was unable to reproduce using transitions with "Don't Keep Activities" enabled. But I've done as you sugested, can you validade with 1.0.0-beta05?

About the key, for that to work the key function must be a property. Since Screen is an interface it can't set the value itself, so every screen would have to do something like override val key = generatedUniqueKey(). This can be avoided by change the Screen to an abstract class, but I don't wan't to do that.

I'll keep looking for options, maybe KSP could help. Feel free to open a new issue about that. And if you have any suggestion will be very welcome :)

from voyager.

adrielcafe avatar adrielcafe commented on May 18, 2024

Fixed in 1.0.0-beta04. Updated the docs with instructions.

Thanks again @Grouen !

from voyager.

Grouen avatar Grouen commented on May 18, 2024

@adrielcafe Still doesn't work when use transitions. Default CurrentScreen() works fine. I think issue is here:

   Box(modifier) {
        items.forEach {
            key(it.screen) {
                navigator.stateHolder.SaveableStateProvider(it.screen.key) {
                    it.content()
                }
            }
        }
    }

Voyager should use it.screen.key instead of it.screen for key.
By The Way, maybe default key implementation should be unique? Something like View.generateViewId()

from voyager.

Grouen avatar Grouen commented on May 18, 2024

I was unable to reproduce using transitions with "Don't Keep Activities" enabled. But I've done as you sugested, can you validade with 1.0.0-beta05?

Issue is fixed, thanks.

from voyager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.