Components returning undefined rather than empty string for false about enzyme-to-json HOT 13 CLOSED

It works ❤️

from enzyme-to-json.

@FezVrasta v3.1.3 is out!

from enzyme-to-json.

Thank you!

from enzyme-to-json.

Hi @ShaneDrury!

As you say I'm checking for null and undefined values, but not all falsy values. Although it seems weird that it give

exports[`falsey case 1`] = `undefined`;

it should give

exports[`falsey case 1`] = `false`;

I will have a look but I think I will stick to an empty string for null and undefined only as you might want to see if you component returns false sometimes.

from enzyme-to-json.

I'm still reproducing something similar (or the same?) with 3.1.2

<div styleName="CarouselDot__inner">
  {!!icon && <Icon styleName="CarouselDot__icon" name={icon} />}
</div>

When icon is evaluated as false the snapshot will read:

<div
  className="CarouselDot__inner"
>
  <undefined />
</div>

If I change it to {icon ? <Icon styleName="CarouselDot__icon" name={icon} /> : null} it works properly.

The weird thing is that my whole project makes use of renders of this kind, and only this component gives me this problem.

Ideas?

from enzyme-to-json.

Hey @FezVrasta, that's my bad, I haven't released a new version including the fix. I'll get v3.1.3 out asap.

from enzyme-to-json.

Nope, no way... I'm getting the same problem of before even with 3.1.3... I double checked it 😓

Note that my component doesn't return just false, it returns something like: <div>{false}</div>

from enzyme-to-json.

@FezVrasta I will have a look now.

from enzyme-to-json.

I'm going to send a PR to add a failing test, if I manage to get one.

from enzyme-to-json.

Don't worry I just reproduced the issue so I have a failing test.

Thanks for reporting the issue by the way.

from enzyme-to-json.

Oh, I just finished the PR lol.

nevermind then 😇

from enzyme-to-json.

Haha sorry, good news is that I fixed it already.

from enzyme-to-json.

@FezVrasta it should be fixed in v3.1.4 🎉

from enzyme-to-json.