Git Product home page Git Product logo

Comments (3)

adrg avatar adrg commented on May 24, 2024

Yes, it could return an error there. However, the runtime directory must be a directory and it must be owned by the current user according to the specifications. On that code path, the file is not a directory. The other thing the specs specify is that the user owner must be the only one with read/write access to it.

$XDG_RUNTIME_DIR defines the base directory relative to which user-specific non-essential runtime files and 
other file objects  (such as sockets, named pipes, ...) should be stored. The directory MUST be owned by the
user, and he MUST be the only one having read and write access to it. Its Unix access mode MUST be 0700.

EDIT: it's a very unlikely scenario. But yes, it probably is a bit harsh to remove it.

from xdg.

KalleDK avatar KalleDK commented on May 24, 2024

Correct, I agree that these are the rules, but if that path exists, and I don't have XDG path setup, a program would simply delete that file.

The way I look at it, if XDG_RUNTIME_DIR is invalid, the the user have an invalid XDG setup, if the user have an invalid setup, a program shouldn't just remove files.

Bu I do agree that an error should be returned, such that we adhere to the rules.

from xdg.

adrg avatar adrg commented on May 24, 2024

Removed the directory verification. If the file is not a directory, createPath will return an error instead.
Closing this issue.

from xdg.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.