Git Product home page Git Product logo

Comments (11)

thetutlage avatar thetutlage commented on May 30, 2024 2

Published as @1.0.29 and sorry for the delays

from session.

ukchukx avatar ukchukx commented on May 30, 2024 1

@thetutlage @targos I see you guys have fixed this since January, why not push a new version?
In my own case, the session logged in the first user in the mongo document regardless of the credentials supplied.
I have to manually edit the bson version in node_modules/@adonisjs/session/package.json and rerun npm i to get things working properly.
I could send the PR if you want.

from session.

targos avatar targos commented on May 30, 2024

I am not a maintainer so I can't publish this package. I have a fork where I published the fix

from session.

mcordoba avatar mcordoba commented on May 30, 2024

@thetutlage any news about this? thank you

from session.

targos avatar targos commented on May 30, 2024

Feel free to install my fork: https://www.npmjs.com/package/@targos/adonis-session
It was published from https://github.com/targos/adonis-session/commits/fork and just contains the bson fix on top of official 1.0.28.

from session.

isocroft avatar isocroft commented on May 30, 2024

@thetutlage @RomainLanz can we have this fix published please.

Just spare a little time from your busy schedule

Thank you.

from session.

thetutlage avatar thetutlage commented on May 30, 2024

Hello @isocroft. No need to beg for anything and really sorry for ignoring the issue. I’ll surely get it published tonight (IST).

Your comment just broke my heart πŸ’”, I wish I can look at most of the issues right away, but it’s impossible

from session.

mcordoba avatar mcordoba commented on May 30, 2024

@thetutlage Thank you for your time! We know you can't look at most of the issues as you are busy.

But in this case, the bug is already fixed in one of the last commits. You only have to tag it.

Thank you again for your awesome work

from session.

thetutlage avatar thetutlage commented on May 30, 2024

Yeah I will. More than busy, I am focusing more on the v5 release and context switching becomes hard at times. :)

from session.

mcordoba avatar mcordoba commented on May 30, 2024

I can't see the tag published yet, is it?

from session.

thetutlage avatar thetutlage commented on May 30, 2024

Screen Shot 2019-07-21 at 10 11 54 AM

from session.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.