Git Product home page Git Product logo

Comments (9)

alltom avatar alltom commented on June 14, 2024

I'd love that. Have you done software translations before? I copied the internationalization file structure from Brackets into Theseus so that it would be possible to add translations, but I've never tried doing so.

If you know what you're doing, you can just get to it and I'll merge. If not, let me know, and I'll poke around to figure out how internationalization works.

from theseus.

marcelgerber avatar marcelgerber commented on June 14, 2024

I've changed a little bit within the brackets-translations, so I think that's no problem.

from theseus.

marcelgerber avatar marcelgerber commented on June 14, 2024

See this: https://github.com/SAPlayer/theseus/blob/master/src/nls/de/strings.js

from theseus.

marcelgerber avatar marcelgerber commented on June 14, 2024

Yes, it works!
image
Unfortunately many things are still english...

Just edited https://github.com/saplayer/theseus/blob/master/src/nls/strings.js to get this to work.

from theseus.

alltom avatar alltom commented on June 14, 2024

Awesome! I'll merge that, and I'll also try to move the rest of the app's strings into the internationalization file. Thank you!

from theseus.

alltom avatar alltom commented on June 14, 2024

Weird, my photo is supposed to be on that screen. I wonder if that's a Windows issue.

from theseus.

marcelgerber avatar marcelgerber commented on June 14, 2024

Yes, I wondered too, but it isn't there (it wasn't there before, too).

from theseus.

marcelgerber avatar marcelgerber commented on June 14, 2024

Okay, I think I've found the problem:
The URL of the pic is invalid:

<img src="file://file:///C:/Users/Marcel/AppData/Roaming/Brackets/extensions/user/theseus/src/tom.jpg" width="48" height="48" align="right">

https://github.com/adobe-research/theseus/blob/master/src/Invitation.js#L44

Responsible for this:

// On Windows, $.get() fails if the url is a full pathname. To work around this,
// prepend "file:///". On the Mac, $.get() works fine if the url is a full pathname,
// but doesn't work if it is prepended with "file://". Go figure.
// However, the prefix "file://localhost" does work.

https://github.com/adobe/brackets/blob/master/src/utils/ExtensionUtils.js#L133

from theseus.

alltom avatar alltom commented on June 14, 2024

Thanks, SAPlayer! I just merged your translation. Thanks a ton for that. I'll get to the Windows image pull request in a bit. :)

from theseus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.