Comments (3)
https://github.com/Admiral-Fish/PokeFinder/blob/master/Source/Core/Parents/EncounterArea.cpp#L58-L92
https://github.com/pret/pokeemerald/blob/master/src/wild_encounter.c#L915-L934
My implementation matches what the game does. Please provide a specific example with how a pokemon you caught in game does not match what pokefinder generated
from pokefinder.
Here is an explicit example: I caught a wild voltorb with Sweet Scent using a static lead in the inner-area of New Mauville.
Level 24
PID 0x789195C8
IVs: 11/2/16/14/9/1
This is a wild H1 encounter which pokefinder says with a static lead can should be either a magnemite or a magneton.
The issue in the implementation is not in the Pokefinder function you highlighted, although technically yours does lack the invalid memory access that Emerald has. Emerald always checks the types of 12 "Encounter slots" even though for Surfing encounters there are only 5. This leads to Emerald also checking the Old Rod and Good Rod encounter slots as well as the types of two glitch species (0x0 and 0x0855). Luckily, none of the Old/Good Rod encounter slots are electric types and neither are either of the glitch species, so this ended up being buggy code that didn't produce bad encounters.
The issue for the difference in behavior between Emerald and Pokefinder is in this line in Pokefinder:
https://github.com/Admiral-Fish/PokeFinder/blob/master/Source/Core/Gen3/Generators/WildGenerator3.cpp#L92
which does not capture both of the cases of the if statement in Emerald:
https://github.com/pret/pokeemerald/blob/master/src/wild_encounter.c#L929
If 12 encounter slots all match the type to be forced, the game recognizes there is no need to change anything about how its generation works and you get the standard encounter table encounter rates instead of every slot getting an equal shake. The only location this is possible to happen is New Mauville, since no other encounter table has 12 steel types or 12 electric types.
from pokefinder.
from pokefinder.
Related Issues (20)
- PIDs from Gen 3 Static for Squirtle are not Shiny even when it says so HOT 2
- Battle Frontier not available as Encounter location HOT 1
- Lost Cave North of Five Island seems to be missing - looking for Misdreavous Pokemon HOT 1
- Snubbull missing from Gen 3 Wild - Location Safari Zone HOT 1
- App constantly crashing when attempting to interact with list in Generator tab. HOT 4
- Gen 8 Profile won't show up HOT 4
- DPPt Maniac Tunnel Slot issue HOT 2
- [Gen 4] Missing "Generate times for seed" option in Event/IDs
- [Gen 4] Seeds displayed in a weird way in Event
- Drop down menu bug on Windows HOT 2
- [Gen 4] HGSS breeding inheritance is a little bugged HOT 1
- Errors when building from on macos (qt = 6.7, cmake = 3.29.2) HOT 10
- Flatpak HOT 4
- [G8] Finder crashes if you pick Static -> Legendary (4.2.0+) HOT 1
- [Gen 3 Emerald] Southern Island Lati@s calculated as RS Roamers
- No Chatot pitches in Gen 4 Event tab
- Allow the Calibration section of Gen 4 Seed to Time window to show more than 59 seconds HOT 2
- When using the Gen 8 Static feature, the Pokemon list is incomplete. HOT 4
- Add support to see Height and Weight when doing Gen 8 Egg RNG
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokefinder.