Git Product home page Git Product logo

Comments (8)

tonivdv avatar tonivdv commented on August 22, 2024

Interesting. Hope I'll find some time to check this.

from docker-machine-nfs.

erikwilson avatar erikwilson commented on August 22, 2024

Thanks, hope you have a chance to check it out! I did some cleanup of the unfs fork, it uses pure bash now, it may work in Linux distros if anyone has the time to test.

from docker-machine-nfs.

konobi avatar konobi commented on August 22, 2024

Nice work... I've been working on something similar.

It would be great to have the shared folder option to have the ability to take a mountpoint name inside the machine... ie: --shared-folder=/User/bob/project:/project.

from docker-machine-nfs.

konobi avatar konobi commented on August 22, 2024

The RancherOS folks have documentation of how to get NFS client mounts going in their documentation. That'd be another great addition.

from docker-machine-nfs.

tonivdv avatar tonivdv commented on August 22, 2024

Hey @erikwilson ,

I took some time to checkout UNFS3 and the changes you made in your fork. Several things pops to my mind:

  • How well maintained is UNFS3? Seems this project is not very active anymore?!
  • I'm not sure switching everything to UNFS3 is the way to go

That being said, I do think, if UNFS3 is actively used by many users that it has it's place. But how to support both system correctly?

It could be as a separate project, but I don't think this will benefit both projects as a lot of functionalities related to docker machine are the same ... Put everything in the same bash file or do it like they do it on the docker-machine project trying to work with "drivers". The idea would then to isolate every common functionalities and implement each specific functionalities in different files ...

These are just ideas so any feedback or other propositions are welcome.

Cheers

from docker-machine-nfs.

konobi avatar konobi commented on August 22, 2024

I forked and added the functionality I mentioned. It's a PR on your fork @erikwilson

from docker-machine-nfs.

erikwilson avatar erikwilson commented on August 22, 2024

Thanks @tonivdv, it does appear that unfs3 is not very well maintained, being on Sourceforge and all. There are a fair amount of daily downloads but the last update was from October of 2015. Looks like maybe a couple updates a year to the project. Was trying to find it on the latest release of Ubuntu, seems there is some issue where it hasn't made it into the Universe repository for 15-10. Hopefully it will continue to be well supported as a brew package.

If you are interested in supporting Unfs3 (or things like RancherOS) I would recommend trying to split the logic up into smaller parts. Unfortunately bash isn't the greatest for modular programming, but would still help to make the code more manageable.

from docker-machine-nfs.

tonivdv avatar tonivdv commented on August 22, 2024

Unfortunately bash isn't the greatest for modular programming, but would still help to make the code more manageable.

I couldn't agree more :) . At one time I was thinking of migrating that to golang (as most of docker stuff is done in that language) ... but currently I got a lot on my plate with our own internal project so not sure when that will see the day.

That being said, even with bash we could do very fancy stuff :)

from docker-machine-nfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.