CPA Signals not passed from Punchblock up about punchblock HOT 3 CLOSED

I've found two ways to make this work:

• In the Blather CoreExt, change it to check for Punchblock::Events or Event::Complete::Reasons:

def rayo_event?
  event.is_a?(Punchblock::Event) || event.is_a?(Punchblock::Event::Complete::Reason)
end

• In the actual Signal, override #is_a?:

class Signal < Event::Complete::Reason

  def is_a?(something)
    something == Punchblock::Event ? true : super(something)
  end
...

If I do either one of those, then I can async watch for CPA events.

component.register_handler :event, Punchblock::Component::Input::Signal do |event|
  yield event if block_given?
end if async?

Thoughts @benlangfeld, on either of those two approaches, or a better approach I've missed? Would you rather have this in Punchblock core, or a monkeypatch in adhearsion-cpa?

from punchblock.

I'd rather have the reason be a Punchblock::Event.

from punchblock.

Fixed by #208.

from punchblock.