Comments (5)
Hey!
Thanks for the comment, I think it should correctly call the encodeUriComponent
function
In https://github.com/addingwell/kwanko-tag/blob/master/template.tpl#L159
function encodeUri(value) {
value = value || '';
return encodeUriComponent(value);
}
Though I do agree it's not the best name, might be best to rename to safeEncodeUriComponent
or something like that.
from kwanko-tag.
I've just published a new release which rename the function: https://github.com/addingwell/kwanko-tag/releases/tag/1.0.1
from kwanko-tag.
Yup you're totally right, my bad.
Would you mind adding that call to the lines below?
Lines 203 to 206 in e80a156
Then we can move forward adding this template to the gallery.
from kwanko-tag.
Would you mind adding that call to the lines below?
Lines 203 to 206 in e80a156
This is done in https://github.com/addingwell/kwanko-tag/releases/tag/1.0.2 ; thanks!
from kwanko-tag.
Looks good, thanks!
from kwanko-tag.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kwanko-tag.