Git Product home page Git Product logo

Comments (6)

kpfefferle avatar kpfefferle commented on May 27, 2024 1

@bakerac4 I'm quickly settling on an approach I'm pretty happy with for the app I work on at Addepar. Once I review it with my own team to get some feedback, I look forward to getting your feedback - as well as anyone else using ember-table with glint!

Thanks for opening this issue to register your interest and kick off a place for others to chime in.

from ember-table.

kpfefferle avatar kpfefferle commented on May 27, 2024 1

I'll leave this issue open for now as we'd like to also consider migrating the Ember Table internals to TS. This would increase our own confidence in the code while also making it easier for consuming apps to extend the Ember Table components and internals as needed.

from ember-table.

kpfefferle avatar kpfefferle commented on May 27, 2024

@bakerac4 Trust me when I say there's support for this inside of Addepar as well. In fact, I may have something for us to look at sooner than you might expect (there may even be a branch on this repo with recent activity that you might find interesting).

I noticed your recent efforts in this direction in the glint-template-types project - thank you for that!

I'm curious: do you have use cases where interacting with the internal types of the ember-table api is needed in your templates? I personally might consider api to be internal/intimate workings of this addon and not something I'm regularly manipulating from my app. I'd be curious to understand when/why you feel that accessing the internal types of that interface would be necessary.

from ember-table.

bakerac4 avatar bakerac4 commented on May 27, 2024

@kpfefferle that sounds exciting!

I don't really need the interaction of the internal api in a consuming package. But I was trying to glint-ify my addon based on ember-table and in that addon I would need that.

In this file we add a few extra niceties such as different automatic loading indicators and a no results component.
https://github.com/Gavant/gavant-ember-table/blob/master/ember-table/src/components/ember-tbody-override/index.hbs

from ember-table.

kpfefferle avatar kpfefferle commented on May 27, 2024

I just opened a PR to add the Glint types I've been using internally as a public experiment:

from ember-table.

kpfefferle avatar kpfefferle commented on May 27, 2024

Addon-provided Glint template types have been released in version 5.0.1. They are considered experimental, may change at any time, and not subject to our semver commitment. Right now these types are limited to the documented public API and standard usage of Ember Table in app templates.

I've been using these types internally with one of our own apps with much success. We welcome any feedback as others try them out!

from ember-table.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.