render tag <%=%> replaced with [object Object] when used in img tag about prettier-plugin-erb HOT 16 OPEN

Downgrading prettier to 2.2.1 did the trick:

   "devDependencies": {
-   "@prettier/plugin-ruby": "^1.5.5",
-   "prettier": "^2.3.1",
-   "prettier-plugin-erb": "^0.3.0",
+   "@prettier/plugin-ruby": "^1.6.0",
+   "prettier": "2.2.1",
+   "prettier-plugin-erb": "^0.4.0",
  },

Actually I also tried without upgrading prettier-plugin-erb to 0.4.0, and it still worked as expected (no [object Object] issue):

   "devDependencies": {
    "@prettier/plugin-ruby": "^1.5.5",
-   "prettier": "^2.3.1",
+   "prettier": "2.2.1",
    "prettier-plugin-erb": "^0.3.0",
  },

from prettier-plugin-erb.

I have located the problem, will fix it tomorrow hopefully. Thanks guys for reporting.

from prettier-plugin-erb.

sorry for the wait, @karthikkasturi

I've just released a fix, please check the version 0.3.0

from prettier-plugin-erb.

Current config:
"@prettier/plugin-ruby": "^1.5.5",
"prettier": "2.2.0",
"prettier-plugin-erb": "^0.2.0",

from prettier-plugin-erb.

Also seeing this, appears to be when the ERB tag is within double quotes:

      =====================================input======================================
      <a href="mailto:<%= contact_email %>"><%= contact_email %></a>

      =====================================output=====================================
    - <a href="mailto:<%= contact_email %>"><%= contact_email %></a>
    + <a href="mailto:[object Object]"><%= contact_email %></a>

      ================================================================================

from prettier-plugin-erb.

any update on this? or a workaround?

from prettier-plugin-erb.

I'm seeing the issue with [object Object] as well. But in another context.

With the following versions

{
  "@prettier/plugin-ruby": "1.5.5",
  "prettier": "2.2.1",
  "prettier-plugin-erb": "0.3.0"
}

Running prettier on this

<script>
  var custom = '<%= data.to_json %>';
</script>

would result in the following

<script>
  var custom = '[object Object]';
</script>

from prettier-plugin-erb.

@marcuslilja I'll try to resolve this one over the weekend, sorry for trouble

from prettier-plugin-erb.

@marcuslilja I'll try to resolve this one over the weekend, sorry for trouble

Thanks 👍

from prettier-plugin-erb.

Same issue also happens with <pre> elements.

Input:
<pre><%= 123 %></pre>

Output:
<pre>[object Object]</pre>

from prettier-plugin-erb.

Hey, chiming in to report the same issue, in another context:

Versions:

    "@prettier/plugin-ruby": "^1.5.5",
    "prettier": "^2.3.1",
    "prettier-plugin-erb": "^0.3.0",

Source:

  <div
    class="form-group mb-3"
    data-controller="avatar-field"
    data-avatar-field-fallback-image-value="<%= image_path "icons/user-astronaut-regular.svg" %>"
  >

Formatted output:

  <div
    class="form-group mb-3"
    data-controller="avatar-field"
    data-avatar-field-fallback-image-value="[object Object]"
  >

from prettier-plugin-erb.

Released a fix, please check 0.4.0.

from prettier-plugin-erb.

Thank you @adamzapasnik... but this seems worse :/

package.json:

   "devDependencies": {
-   "@prettier/plugin-ruby": "^1.5.5",
+   "@prettier/plugin-ruby": "^1.6.0",
    "prettier": "^2.3.1",
-   "prettier-plugin-erb": "^0.3.0",
+   "prettier-plugin-erb": "^0.4.0",
    "webpack-dev-server": "^3.11.2"
  },

Input:

  <div class="form-group mb-3">
    <%= form.label :name, "Full name" %>
    <%= form.text_field :name, value: params[:name] || customer.name, class: "form-control", placeholder: "First name + last name" %>
  </div>

  <div
    class="form-group mb-3" 
    data-controller="avatar-field"
    data-avatar-field-fallback-image-value="<%= image_path "icons/user-astronaut-regular.svg" %>"
  >

Output:

  <div class="form-group mb-3">
    <eext7 />
    <eext8 />
  </div>

  <div
    class="form-group mb-3"
    data-controller="avatar-field"
    data-avatar-field-fallback-image-value="eex9eex"
  >

from prettier-plugin-erb.

I am still having this problem even with the above package versions. It seems to only apply for ERB tags nested inside of specific other tags.

EDIT: Maybe it's broken for specific tag types? If I have an ERB tag inside of a <p> it's fine, but inside of a <title> it breaks.

from prettier-plugin-erb.

This issue is still present for all tag types present in this array.

https://github.com/adamzapasnik/prettier-html-templates/blob/master/lib/tokenizer.js#L39

from prettier-plugin-erb.

Still an issue inside <title> tags for these deps

{
  "devDependencies": {
    "@prettier/plugin-ruby": "1.5.5",
    "prettier": "2.2.0",
    "prettier-plugin-erb": "0.2.0"
  }
}

Also for 0.3.0. But it seems to work with 0.4.0.

from prettier-plugin-erb.