`damping` arg ignored in `lexRankFromSimil` about lexrankr HOT 5 CLOSED

There is the minhash algorithm which I tried to wrap in the textrank package: https://cran.r-project.org/web/packages/textrank/vignettes/textrank.html#minhash but that requires knowledge of the useR on that algorithm. If you know of another way, also feel free to let me know :).

from lexrankr.

Thanks for pointing out the issue with damping; I will fix it.

The only step I have taken to reduce the computation (time) is to write a minimal Rcpp function to perform the similarity calc. Some parallelization could also provide some benefit here.

Another possibility would be to get creative, deviate from the methodologies laid out in lexrank/textrank, and think of a new way to get valid sentence ranks without the cumbersome pairwise comparisons. Of course, I haven't thought of a valid way, but I'd be interested in learning more about a method if there is one out there.

from lexrankr.

FYI going to rename to focus on damping issue and close this when it is fixed

from lexrankr.

Hi! Thank you for maintaining this package. This package saved me LOADS of time! I cannot thank you enough. I may have found the line in the code that is potentially the issue so I thought I might share this with you. The original is sentRank <- igraph::page_rank(sentGraph, directed = FALSE)$vector. I think to take in the damping argument, it should be sentRank <- igraph::page_rank(sentGraph, directed = FALSE, damping = damping)$vector. Hope it helps you =) Thanks!

from lexrankr.

Thanks for re-pinging this issue @wenyi-tay. I've committed the fix (which was exactly as you outlined) and will re-publish to CRAN assuming all tests are 👍.

If you do find any other issues and see the correct fix (as you did this time), please feel free to submit a PR. I haven't been very active with this project lately, so I'll rely on feedback/PRs from any users.

from lexrankr.