PacketlistAPI from swift about webmidikit HOT 6 CLOSED

Thanks for the info. I used to handle this case.

https://github.com/adamnemecek/WebMIDIKit/blob/a042248820c930fb83a2866e1e9475a9ae01484a/Sources/AXMIDI/AXMIDI.c

I think that at one point, my code was similar to yours but eventually decided to drop the C dependency for easiness when I realized that I think that your case mostly likely wont actually happen.

The reason for that is that I dont think that people are sending anything but notes or other short messages with their keyboardds. No one actually uses the dynamically sized messages. They might do it in MIDI files but definitely not for midi recording.

Lemme know what you think.

from webmidikit.

Thanks for the reply.
I agree, most people would use it that way.

I stumbled into this pointer issue when I tried to read data out of MusicEventUserData delivered by a sequence callback. I could not find a decent way to get a pointer to the data field of UnsafePointer< MusicEventUserData >. The only thing that worked in swift was calculating the offset of the data field in the struct but that indeed looked very ugly.

Using a simple c-function to return the pointer from the struct seemed much safer to me.
So I am dependent on c anyway (like anybody using CoreMIDI). The only effort to use this function is to include a bridging header.

The same problem would apply when reading meta events or sysex data from a sequence.

The only thing that would matter to me in reading packet lists would be performance.
I don't think that a c-function call will cause much overhead. When using CoreMIDI in swift you call c-functions all the time.

from webmidikit.

It was not a performance decision. You can always get a UnsafePointer to the data, or use the Data (aka NSData) class.

The overhead was due to the package structure not performance. Including C in an SPM package is annoying. I used to have it but removed it.

from webmidikit.

Thank for your reply.
Your remark 'you can always get a UnsafePointer to the data' made me think about it again.
With a little effort and some awkward lookin swift expressions I managed to remove all c-functions.

from webmidikit.

Are you aware of the audiokit project? https://github.com/AudioKit/AudioKit/ I'll invite you to the slack group, you'll fit right in.

from webmidikit.

What's your email?

from webmidikit.