Theme with virtualfish prompt support about virtualfish HOT 7 CLOSED

Even in the scenario you describe, you would still be required to edit config.fish manually:

1. install Oh-My-Fish
2. modify ~/.config/fish to switch to the bobthefish theme

I don't think the above is any easier than than adding VirtualFish to one's prompt. In fact, I think it's harder.

from virtualfish.

@justinmayer
OK, I wasn't satisfied with the solution you've linked to (color is too bright and it looks bad with the bobthefish theme), so I made my own prompt. I'm just proposing. Moreover, user could have already installed oh-my-fish.

from virtualfish.

Okay, but if users already have Oh-My-Fish installed, then presumably they know they should be looking for a theme that displays virtual environments in the prompt.

I don't think there's anything needed here on the Virtualfish side of things.

from virtualfish.

There are lot's of themes in oh-my-fish. I'm not proposing to break something or make something big, Just a simple sentence.

Well, I'm not going to waste my time speaking on such petty things. In any case it would be @adambrenecki decision.

from virtualfish.

If you feel documentation changes are warranted, I believe the best place for that would be within the Oh-My-Fish project.

from virtualfish.

I agree with @justinmayer. You can't expect virtualfish to document every project that integrates with it.

from virtualfish.

I'm in two minds about this. On one hand, I agree with @justinmayer - there's code to handle virtualfish in bobthefish, and not the other way around, so that's probably where documentation about it should go. On the other, I'm totally OK with the idea of having a docs page of 'other stuff that works with virtualfish'.

from virtualfish.