Update DIS about adafruit_nrf52_arduino HOT 9 CLOSED

default values here https://github.com/adafruit/Adafruit_nRF52_Arduino/blob/master/libraries/Bluefruit52Lib/src/services/BLEDis.cpp#L43

from adafruit_nrf52_arduino.

For Firmware version

• ARDUINO_BSP_VERSION : usually is 3 number e.g 0.2.0 Do you purposely drop the least number ???
• SD Version is 2.0.1 ( 11.2 is SDK version)

For Software_Rev and Hardware_Rev default values is NULL which mean it is not populated in the DIS

from adafruit_nrf52_arduino.

Maybe SD_Version is integrated into SD_NAME as well, and have the bootloader to be 3 number to be consistent e.g 0.4.5,0.5.0,S132v2.0.1 ??

from adafruit_nrf52_arduino.

OK, let's do this: `0.5,S132,2.0.1,0.4.5' = 20 chars ... I prefer another ',' to the 'v' to be consistent, and then they are in a logical order:

• Bootloader version
• SoftDevice Family
• SoftDevice Version
• BSP Version

from adafruit_nrf52_arduino.

no problems, I think bootloader should also be 3 number since we couldn't change 0.5 -> 0.6 since nordic API() use that to indicate whether it is in DFU or not. When we change our customized code, we likely to increase from 0.5.0 to 0.5.1 or so.

PS: the BSP is likely to increase to 0.10.10 so it is 22-24 bytes ??

from adafruit_nrf52_arduino.

I think we should also make the OTA DIS to be consistent as well for now, it is

• Manufacturer = Adafruit Industries
• Model = Bluefruit Feather52 --> drop to simply Feather52 only
• There is no firmware rev now, it should contain only bootloader + SD e.g 0.5.0,S132,2.0.1 (omit the Arduino BSP version)

from adafruit_nrf52_arduino.

Ack, you're right. OK ... the BSP actually isn't SUPER important since that only goes into user code anyway, the bootloader and SD are the most important since those are hard coded and can't be easily changed by the user.

Lets just display:

• BOOTLOADER (x.x.xx)
• SD Family (S132)
• SD Version (xx.xx.xx)

So: x.x.xx,Sxxx,xx.xx.xx = 20 bytes

from adafruit_nrf52_arduino.

Got it, then

• we should change Model in application to Bluefruit Feather52 as well ??
• ARDUINO BSP VERSION can be default value for Software Chars. User can change it if they like :)

from adafruit_nrf52_arduino.

Arduino BSP as default 'Software Char' seems like a good idea, yes.

from adafruit_nrf52_arduino.