Git Product home page Git Product logo

Comments (6)

FoamyGuy avatar FoamyGuy commented on July 18, 2024

This is the link to use for the python source code for all libraries in the bundle
image

It looks populated correctly as far as I can tell. I don't believe the links below are intended to have things in them, but I'm not certain.

from adafruit_circuitpython_bundle.

clickonben avatar clickonben commented on July 18, 2024

So what you are saying is that the files named "source code" don't contain much if any source code and are supposed to be mostly just empty directories?

Assuming there is some purpose to these files that escapes me, I would politely suggest that they are renamed or at least an explanation is added to the download page that the archive files that are labelled "source code" aren't the ones that contain the source code.

from adafruit_circuitpython_bundle.

FoamyGuy avatar FoamyGuy commented on July 18, 2024

I think the links for Source Code zip and tar.gz are created automatically by Github and it seems that they are known to not populate code for submodules based on the discussion here: softprops/action-gh-release#220

I didn't dig too deep but it after a quick look it doesn't seem possible to disable them or rename the links to something different unfortunately. Perhaps we can try to come up with some clarifying language to add to the release notes.

from adafruit_circuitpython_bundle.

jepler avatar jepler commented on July 18, 2024

I want to confirm what @FoamyGuy says -- as far as I know there is no way to remove or suppress the "source code (zip)" or "source code (tar.gz)" links that are automatically added by github, and there's no way to make them include the content of the files that are actually used to build the bundle.

If there's something actionable about this for us, it could be to add a note in the standard release notes that says that due to github technical limitations those links are not useful. Otherwise, there does not seem to be much that we can do.

from adafruit_circuitpython_bundle.

dhalbert avatar dhalbert commented on July 18, 2024

I was looking for the standard release notes template, but could not immediately find where they came from, even with GitHub organization search. I agree that's what's to be done here. I did something similar in the release notes for adafruit/circuitpython.

from adafruit_circuitpython_bundle.

jepler avatar jepler commented on July 18, 2024

It looks like the text we use comes from adabot

adabot/circuitpython_bundle.py:        " Please download the one that matches the major version of your CircuitPython. For example"

from adafruit_circuitpython_bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.