Scope chaining broken on Rails 4.2.5.1? about acts_as_paranoid HOT 7 CLOSED

@mvz Do you have any ideas about this?

It seems like it might be related to 3bf46c2 or 01bdce8

from acts_as_paranoid.

Yes, I kind of see what happens: .without_paranoid_default_scope does a check that is supposed to differentiate between AR4.1 and lower. But since .unscoped already removes the acts as paranoid scope, the check has the wrong result.

That needs to be fixed of course, but I do wonder why you would call .unscoped.with_deleted, since the .unscoped should already give you the deleted records. @timfenney can you shed some light on that please?

from acts_as_paranoid.

I'll see if I can provide a fix as well.

from acts_as_paranoid.

@mvz Thank you! 🙇

from acts_as_paranoid.

Now that you mention it I am not sure of the utility of the scope chaining example I had provided. It is probably just that that was in our codebase somewhere, and tests started failing after upgrade to Rails 4.whatever.

from acts_as_paranoid.

I tried to reproduce this on current master and failed. Then I discovered this was already fixed in 7114ab0, with proper checks for the AR version 😄.

from acts_as_paranoid.

Great, thank you @mvz for your investigation <3 <3 <3

Closing this then!

from acts_as_paranoid.