Binary files using serverless-offline about serverless-aws-static-file-handler HOT 5 CLOSED

Thanks for letting me know @chrisrothwell ! 👍

Looks like a bug. The binary support via API Gateway used to be non-trivial, but it looks like it has improved. I think the key part of the bug is at https://github.com/activescott/serverless-aws-static-file-handler/blob/master/StaticFileHandler.js#L141 - Note how if it is text it adds response headers, but if binary just returns the whole blob (without setting any headers).

As I mentioned, the binary support via API Gateway used to be wonky but it looks like they have improved it:

If body is a binary blob, you can encode it as a Base64-encoded string and set isBase64Encoded to true. Otherwise, you can set it to false or leave it unspecified.

So I think now, we could just have the binary code path return something more like the following instead:

let response = {
          statusCode: statusCode,
          headers: {
            'Content-Type': mimeType
          },
          isBase64Encoded: true,
          body: Buffer.from(stream).toString('base64')
}

Would you be up for submitting a pull request for this with an example and tests? If not, if you could create a very simple example repo demonstrating problem in a public github repo and reply here with a link, I'll use that to fix the issue, confirm it works with your test repo, and write some tests to make sure it stays stable.

from serverless-aws-static-file-handler.

I'm working on this issue...

from serverless-aws-static-file-handler.

This should now let you do what you want if you using Lambda Proxy Integration with the new 2.0.0-beta1 release. Get it from npm. Please feel free to re-open the issue if you have questions, concerns, or suggestions.

from serverless-aws-static-file-handler.

Hi, sorry, I just came back to this project and it seems to work great now :)

Chris.

from serverless-aws-static-file-handler.

Thanks for leaving a note @chrisrothwell !

from serverless-aws-static-file-handler.