Comments (8)
Awesome - thanks for confirming, @kyletaylored! 🫡
from postmark-wordpress.
Hey @bhubbard - Should we be checking those constants from Postmark_Mail
(postmark.php
) are defined in class-postmark-debug.php
or could we concatenate the constants with an empty string on these lines to resolve these warnings? I don't quite get why this warning would be shown at all since all the $debug_info['postmark-wordpress']
array keys are quoted and POSTMARK_DIR
is being used for a string value.
from postmark-wordpress.
@pgraham3 Hmm yeah it's not clear why those would be undefined unless the plugin was modified or running in a non-typical method. We could probably update the debug file to do a check to kill the notice, something like this:
defined( POSTMARK_DIR ) ? POSTMARK_DIR : 'NOT DEFINED';
Ideally if not defined we display the text in yellow or red to let them know it's probably an issue.
from postmark-wordpress.
I'm actually getting this as a Fatal Error
vs just a warning on the Site Info page.
Fatal error: Uncaught Error: Undefined constant "POSTMARK_VERSION" in /code/wp-content/plugins/postmark-approved-wordpress-plugin/includes/class-postmark-debug.php:34
Stack trace:
#0 /code/wp-includes/class-wp-hook.php(307): Postmark_Debug->debug_info(Array)
#1 /code/wp-includes/plugin.php(191): WP_Hook->apply_filters(Array, Array)
#2 /code/wp-admin/includes/class-wp-debug-data.php(1461): apply_filters('debug_informati...', Array)
#3 /code/wp-admin/site-health-info.php(32): WP_Debug_Data::debug_data()
#4 /code/wp-admin/includes/class-wp-site-health.php(66): require_once('/code/wp-admin/...')
#5 /code/wp-includes/class-wp-hook.php(307): WP_Site_Health->show_site_health_tab('debug')
#6 /code/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters('', Array)
#7 /code/wp-includes/plugin.php(476): WP_Hook->do_action(Array)
#8 /code/wp-admin/site-health.php(205): do_action('site_health_tab...', 'debug')
#9 {main} thrown in /code/wp-content/plugins/postmark-approved-wordpress-plugin/includes/class-postmark-debug.php on line 34
PHP Version: 8.0.21
WordPress Version: 6.0.1
Plugin version: 1.17.1
from postmark-wordpress.
I have a proposed PR for this here. Mind taking a look at that @bhubbard?
I also have it up as a tag (1.17.2
) on the plugin marketplace.
@kyletaylored can you try out version 1.17.2
and let me know if that resolves the error?
You can update to version 1.17.2
using the wp-cli
:
$ wp plugin update postmark-approved-wordpress-plugin --version=1.17.2
from postmark-wordpress.
Error still seems to persist.
Fatal error: Uncaught Error: Undefined constant "POSTMARK_VERSION" in /code/wp-content/plugins/postmark-approved-wordpress-plugin/includes/class-postmark-debug.php:36
Stack trace:
#0 /code/wp-includes/class-wp-hook.php(307): Postmark_Debug->debug_info(Array)
#1 /code/wp-includes/plugin.php(191): WP_Hook->apply_filters(Array, Array)
#2 /code/wp-admin/includes/class-wp-debug-data.php(1461): apply_filters('debug_informati...', Array)
#3 /code/wp-admin/site-health-info.php(32): WP_Debug_Data::debug_data()
#4 /code/wp-admin/includes/class-wp-site-health.php(66): require_once('/code/wp-admin/...')
#5 /code/wp-includes/class-wp-hook.php(307): WP_Site_Health->show_site_health_tab('debug')
#6 /code/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters('', Array)
#7 /code/wp-includes/plugin.php(476): WP_Hook->do_action(Array)
#8 /code/wp-admin/site-health.php(205): do_action('site_health_tab...', 'debug')
#9 {main} thrown in /code/wp-content/plugins/postmark-approved-wordpress-plugin/includes/class-postmark-debug.php on line 36
from postmark-wordpress.
Thanks @kyletaylored! I see the issue.
I needed to have the constants' names in quotes for the defined()
check. I just updated the 1.17.2
tag with that change.
Please reinstall version 1.17.2
and let me know how it goes.
from postmark-wordpress.
Yep, that did it!
from postmark-wordpress.
Related Issues (20)
- Please bump Compatible up to: 6.2.3 to 6.3 or the upcoming 6.4 HOT 1
- v1.20.0 Newlines -> Line Breaks
- Support installation with composer (add composer.json)
- ErrorCode 403 : Invalid request field(s): $.Metadata
- Add stream name as a 'recognized' header
- Clearly indicate errors in the logs page UI
- Support wp_mail_from_name filter
- Wordpress Error on Upgrade to v1.13.0 HOT 3
- Support for WP_Environment_Type
- Plugin not working - because it is overwritting the wp_mail() function HOT 3
- Environment based settings HOT 5
- Obfuscate API Token in Settings Page
- Add Message Stream Support HOT 2
- Show error message if plugin cannot be enabled HOT 1
- Postmark not pruning old log entries HOT 3
- Graceful timeout handeling HOT 1
- Apply pre_wp_mail filter to wp_mail() override HOT 6
- Manage Templates and Layouts from WordPress
- E_ERROR from file class-postmark-debug.php HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from postmark-wordpress.