Access to feature branch name from Context about toolkit HOT 8 CLOSED

@damirstuhec as documented on: issues: triggers will always run on the default branch as issues don't really have a ref they are associated with.

from toolkit.

Not sure I completely understand the ask, but in general github.context.ref should have branch info if its available I believe.

I guess I'm not really sure what you mean by "the feature branch from which the comment originated though" - comments aren't really inherently tied to branches - I may be missing something though.

from toolkit.

I'd like access to the branch name generally in the workflow too. I'm porting some things from Travis and I currently upload test results and logs to S3 (to power a web-based dashboard) in a folder {branch_name}/{hash} but using github.ref results in them going in a folder called /refs/heads/{branch_name} which is weird (alternatively, a function that can be used to strip it off would work too).

from toolkit.

Yeah, a convenience function there seems like it could be nice. For now, you can probably do something like:

var branchName = github.context.ref;
if (branchName.indexOf('/refs/heads/') > -1) {
  branchName = branchName.slice('/refs/heads/'.length);
}

from toolkit.

@damccorm in my case I'm just trying to use it in the workflow file rather than an action - I don't think I can put arbitrary JS in there?

  - name: Upload logs to Amazon S3
    run: dpl --provider=s3 --local-dir=".test_results" --upload-dir="${{ github.ref }}/${{ github.sha }}"

from toolkit.

@damccorm

var branchName = github.context.ref;
if (branchName.indexOf('/refs/heads/') > -1) {
  branchName = branchName.slice('/refs/heads/'.length);
}

I tried that but the branchName is always master, even when the issue_comment is posted on another branch (PR).

Basically, my use case is a workflow that runs when a specific issue_comment is posted on a feature branch (PR) which will then trigger a CircleCI job for that branch through their API. Unfortunately, CircleCI only supports triggering the build by a branch name.

from toolkit.

@damirstuhec I don't know if it'll be populated for comments, but there's a head_ref and base_ref listed here. It says they're only populated for PR events, but I'm not sure exactly what that means.

from toolkit.

Closing this out since @chrispat answered ^^ and not so much a toolkit issue. Thanks!

from toolkit.