Actions and services feedback (health check questions) about example-services HOT 12 OPEN

@dentarg I've had the same troubles trying to get RabbitMQ to start healthily here. I posted a thread at github.community with the same issue.

I'll keep an eye on both!

from example-services.

The only recent changes we have made in the are of service containers was to stop overriding the workdir and adding the workspace volume mounts. It is possible that is part of what resolved your issue.

https://github.blog/changelog/2019-09-18-improvements-to-github-actions/

If everything is good here please close out the issue.

from example-services.

@chrispat can you comment on the last part of my post, how would one debug an issue like this if it happens again? is it possible for GitHub Actions to print more debug info? (see the suggestion in my post)

from example-services.

@chrispat Sounds like that might have been the real fix then! Cool!

Along with @dentarg, I'd love to know any methods of debugging these issues ourselves in the future if there's a way!

from example-services.

@jpwilliams RabbitMQ is now starting for me, for example here: https://github.com/dentarg/actions-test/commit/ac7b4ed6aae34a1682166fbc8e03871ac80577d3/checks#step:2:128

from example-services.

@dentarg Absolute star. I tried lots of different thins, but, following your example, the final changes were image from rabbitmq:management to rabbitmq:latest and the options for the service from:

options: '--health-cmd "nc -z localhost 5672" --health-interval 10s --health-timeout 10s --health-retries 6 --health-start-period 60s'

To:

options: --health-cmd "rabbitmqctl node_health_check" --health-interval 10s --health-timeout 5s --health-retries 5

Very glad it's working, but was this actually a meaningful change or have they fixed something behind the scenes anyway? :D

from example-services.

@jpwilliams The changes did two things:

The difference between the rabbitmq:management and rabbitmq:latest images, is that the former includes the management plugin installed and enabled by default. (That's documented on https://hub.docker.com/_/rabbitmq)

rabbitmqctl node_health_check does a lot more than nc -z does. I got that command from docker-library/rabbitmq#174.

However, I suspect GitHub to have tweaked things behind the scenes as I did not touch my setup between when it wasn't working (28 days ago) and now, when it is working.

from example-services.

@dentarg Aye I'm aware of the two changes there, but I don't think either are what actually made it work, is all.

The inclusion of the management plugin shouldn't really affect the usual working of RabbitMQ (and I had tried without before too) and even just waiting for RabbitMQ to start (using no health checks) didn't work, so the health check wasn't the real issue.

Still, very happy it's working now and, aye, I think something changed behind the scenes, which shows GitHub hard at work on the beta! :)

from example-services.

Would be nice to add the rabitmq service as an example into the repo
Was looking for it myself :)

from example-services.

Hi @jpwilliams could you please add a bit more details about your solution wtr RabbitMQ and Actions ? I am running into the issue where I can't connect to the RabbitMQ service from a pika library call. Thanks !

from example-services.

Hi @Roland-djee!

My post here at the GitHub Support Community outlines it a bit better.

A working example can be seen at jpwilliams/remit/.github/workflows/pushtest.yml.

from example-services.

@jpwilliams Thanks for the prompt reply ! Actually I get everything working from the service side :) Thing is, when I try to open a pika connection from a python script, it never succeeds. Have you had any more success perhaps ?

from example-services.