Comments (3)
Hi, @sffc! Is there any reason not to add -D warnings
directly to the args
input, as in args: --all-targets --all-features -- -D warnings
?
That should (as usual) make clippy
exit if there were any warnings, and as a consequence, fail the check too.
Speaking about the clippy annotations, there is a "nextgen" clippy
Action exists, which should solve some of the problems you mentioned in the original issue (to be more specific, it will work for all PRs).
Unfortunately, the only way to make it work right now is to use unstable GitHub feature (I'm actually not sure in what state it is right now, as the tracking issue is in stale state since October and GH staff is not very helpful in providing any sort of ETA), but if you up to some "potentially broken" scripts in your CI, you can give it a shot.
from clippy-check.
@svartalf Earlier testing iterations of the workflow did indeed include ... -- -D warnings
in the args to the clippy Action, but it did not fail the job / workflow as expected (test ex 1, test ex 2). The next test was successful after dropping down from the clippy Action to running Cargo at the CLI.
@sffc 's pasted snippet was taken from the current iteration of the workflow, after the clippy step had been split up into 2 jobs -- one uses the clippy Action to get the awesome Github UI integrations, the other job runs cargo clippy
at the CLI in strict mode to get the job / workflow failures.
from clippy-check.
When it comes to the warnings being treated as errors, I just realized that this functionality fix was already made in v1.0.2. Sorry about that.
That leaves us with the annotations concern, and that is too bad that we can't tell how the progress is coming along. Since that is the only part remaining here, I think we might be able to close this issue as a duplicate of #2 .
from clippy-check.
Related Issues (20)
- Annotations fail on jobs with multiple targets
- clippy job succeeds even when clippy_check fails
- Option to only create annotations instead of using a separate check run
- Support outputing raw 'clippy' output into a file HOT 2
- [Documentation] Mention github_token required permissions HOT 1
- Clippy action not properly reporting ICEs
- Maintenance Status HOT 3
- Cannot output to SARIF file HOT 1
- Use the new GitHub job summaries
- Resource not accessible by integration (no fork involved) HOT 6
- Need to update to Node 16 HOT 3
- Check failing with "Resource not accessible by integration" HOT 26
- Support "working-directory" input HOT 7
- JSON output failing to be parsed HOT 1
- `toolchain` argument doesn't work? HOT 4
- result annotation sometimes gets added to the wrong workflow HOT 2
- ##[error]Validation Failed: {"resource":"CheckRun","code":"invalid","field":"annotations"}
- Quiet / silent flag
- Option: Set commit status to failed if any lint warnings are posted HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clippy-check.