Dredd fails because of setting encoding about drakov HOT 7 CLOSED

Good question @gillesdemey there's requirement to set the charset in the response.

Just curious, may I ask why you are running Dredd against Drakov?

from drakov.

I think if there is no good reason for us to set the character encoding we can take that line out 👍

from drakov.

No particular reason, I just wanted to give Dredd a try and I didn't want to create an express application — so Drakov seemed like the perfect solution :)

from drakov.

@gillesdemey We have removed the encoding from the request. Turns out, however, that Express implicitly adds a the default character encoding on all responses if it is not specified.

Perhaps this is something which Dredd should not enforce on this particular header.

We are going to do a spike in here but we are not sure if it is something Drakov could address.

from drakov.

@gillesdemey

We figured out that Express explicitly sets the charset to utf-8. https://github.com/strongloop/express/blob/master/lib/response.js#L148

Even when the response body is an object. It converts it to string and call send again.
https://github.com/strongloop/express/blob/master/lib/response.js#L233

As we understand that Drakov must strictly follow what is defined in the blueprint file, we decided to handle it and we have pushed a fix to this scenario. 9a49bc8

It should address your situation with Dredd.

Let us know how it goes.

from drakov.

I'll check it out again tonight and I'll let you know.

I didn't know that Express actually looked at the response body type, interesting :)

Thanks for all the effort you've put into this, even though I understand that the use-case is pretty weird.

from drakov.

The fix is working, no more fails! 👍

from drakov.