Use custom CSR about acmephp HOT 2 CLOSED

I like the idea!

To keep BC, I think the best way to do it to:

• Update CertificateRequest to add methods isSigned, setSignature, getSignature
• Create a CertificateRequestFactory with methods createFromString, and createFromDistinguishedName (don't forget to parse the string and provide a DistinguishedName. Beware some methods like requestCertificate uses the $csr->getDistinguishedName()->getSubjectAlternativeNames() which rely on subject alternatives name inside the CSR, but methods like openssl_csr_get_subject may not return those informations)
• Update the signCertificateRequest method to skip signature if the certificate is alreadySigned
• You could also use the new getSignature method in finalizeOrder

Would be happy to accept such PR :-)

from acmephp.

But i think it might be conflicting with install feature (If subscriber does not use this, ignore then).

Reason:

• Install feature need to read privateKey.
• Provide csr means privateKey is not readable for ACME PHP (or other clients, whatever)

So, i think we'd to figure it out before trying to make it.

from acmephp.