Comments (8)
I will give it a try.
from acmephp.
YES, that would ease a lot. This should be quite easy to implement:
In EmailHandlerBuilder, check if smtp host is set. If not, use the NativeMailerHandler instead of the SwiftMailerHandler.
from acmephp.
Actually I am requesting this be compiled into the .phar and implemented via the ~/.acmephp/acmephp.conf
config file. Currenntly, it says only SMTP is supported for the monitoring email.
from acmephp.
Hello @LeftPinkie,
Thanks for the proposal, it would be indeed useful. Would you have time to try to work on it? This would involves updating https://github.com/acmephp/acmephp/blob/master/src/Cli/Monitoring/EmailHandlerBuilder.php, it shouldn't be too difficult (get the config, check if the "transport" option is defined and what values it is and send the mail using the appropriate transport). Would you be interested in giving it a try :) ? I can help you do so if you want.
from acmephp.
Awesome, thanks! Don't hesitate to ping me here or on Twitter (https://twitter.com/titouangalopin) if you need a hand :) .
from acmephp.
I am re-thinking this request. For the purpose of cross-platform compatibility, using sendmail or PHP mail() on a Windoze system may be problematic if PHP is not configured correctly. Since I don't have access to a Windoze platform to test... is it really worth implementing this request just for Linux? I am thinking SMTP is universal enough. Any thoughts?
from acmephp.
I think it's worth it, especially because you only have to rely on SwiftMailer SendMail transport: https://swiftmailer.symfony.com/docs/sending.html#the-sendmail-transport, the aim being only to choose between the SMTP or SendMail transport on https://github.com/acmephp/acmephp/blob/master/src/Cli/Monitoring/EmailHandlerBuilder.php#L49. It does not involves a lot of complexity :) .
from acmephp.
Another +1 for it's worth it. For a good coder it's faster to implement that than set up a SMTP server ;-).
Also some people (including me) don't like having SMTP passwords on a config file. Accidentally pushed to a public repo and boom we have Spamgun.
from acmephp.
Related Issues (20)
- Error During Renewal HOT 2
- website updates? HOT 1
- getResponseBodySummary(): Return value must be of type string, null returned HOT 1
- "OpenSSL signature could not be verified" on Centos 9 (and other updated SSL stacks)
- Format output for commands
- Feature Request: Customizable truncation char limit for RequestException Errors. HOT 2
- Is this project still maintained? HOT 2
- Short / Alternate chain in acme-php ? HOT 1
- Proposal for v3 HOT 10
- Single certificate renewal failure with run command
- Domain name character capitalisation leads to ChallengeNotSupportedException
- Retry on 503s with RetryAfter? HOT 1
- Upgrade PHP to V8 HOT 4
- Maintenance HOT 6
- Proposal: remove @author tags HOT 8
- Proposal: Make classes final & readonly
- Issue with using Symfony Serializer HOT 11
- Subtree does not work anymore? HOT 5
- Improve call examples HOT 4
- Wildcard Domain Authorization using DNS Solver not supported anymore?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from acmephp.