Comments (3)
This package follows semver but unintentionally we have broke backwards compatibility in 1.2.1. I'm sorry, it is my fault.
Thank you for this issue, which let me know the backwards incompatibility.
I'll release a new version to fix the incompatibility in the adapter interface as soon as possible.
If we have an empty setContext function would we still see the old behaviour?
If your custom adapter inheriting a built-in adapter like below, I recommend to use the parent implementation.
class CustomAdapter extends \Ackintosh\Ganesha\Storage\Adapter\Memcached
{
// Comment out to use the parent implementation
// public function setContext(Ganesha\Context $context): void
// {
// }
}
If your custom adapter using no built-in adapter, it is no problem with an empty setContext.
from ganesha.
Thank you for your kind and timely response.
No worries on the backwards compatibility break, mistakes happen! What is more important is that you intend to follow semver which renews my confidence in the package :)
My implementation does not extend any of the built in adapters, as i'm allowing Laravel to choose which underlying cache driver to use.
Thanks for the confirmation on the empty setContext, and thanks for the fix for the bc break.
If i get time i may submit a PR containing the Laravel cache adapter i have written.
from ganesha.
@madbriller I have released v1.2.2 to fix the incompatibility but unfortunately this release does not completely fix the incompatibility.
An empty setContext is still required for custom adapter users.
https://github.com/ackintosh/ganesha/releases/tag/1.2.2
from ganesha.
Related Issues (20)
- Symfony HTTPClient ServiceNameExtractor doesn't support base_uri
- Support for psr/http-message 2 HOT 3
- Call to undefined function GuzzleHttp\Promise\promise_for() HOT 1
- Request to Add FailureDetectorInterface to GuzzleMiddleware in 2.x Version
- Creating new strategies HOT 2
- Adapter Redis HOT 7
- Redis adapter: Count strategy support HOT 3
- Documentation on strategies HOT 3
- Drop PHP5.x support
- Packagist not listing v0.4.2 HOT 3
- Redis Success key keeps growing HOT 5
- Thanks @Wikia for using Ganesha HOT 1
- Better validation for build parameters
- PHPStan HOT 2
- Symfony HttpClient Integration HOT 2
- Success key cleanup - Redis adapter HOT 12
- [GuzzleMiddleware + GaneshaHttpClient] Option to trigger failure on 5xx response HOT 2
- Drop PHP7.1 and 7.2 support
- MongoDB adapter - SlidingTimeWindow support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ganesha.