Comments (2)
achanda
commented on August 20, 2024
Hi 👋 sounds like you want a conversion from Ipv6Addr to Ipv6Network to error out, but that does not happen due to this impl https://github.com/achanda/ipnetwork/blob/master/src/ipv6.rs#L315 so you want to remove those impls. Is that correct? What would the type signature of the single constructor be?
from ipnetwork.
sunshowers
commented on August 20, 2024
Thanks for the quick response! Yes, I'm suggesting removing those impls. It'll be a breaking change, but I think one that's good from an API misuse perspective.
How about just an Ipv6Network::single(addr: Ipv6Addr) constructor? I'm not saying don't provide this, I'm just saying that it would be nice for that to be more explicit.
from ipnetwork.
Related Issues (20)
- Relicense to a dual license? HOT 2
- IpNetwork::size() overflows if the prefix is 0 HOT 6
- This crate's Cargo.toml claims to support serde < 1.0 but it doesn't
- Implement TryFrom<&str>
- Iterators are not public
- [Change suggestion] Resetting the device bits to 0 when initiating new objects
- Ipv6Network::nth
- New release? HOT 2
- is_supernet_of does not work properly HOT 1
- JSONSchema implementation HOT 1
- How to create CIDR from network and broadcast? HOT 1
- JSON schema for IpNetwork does not match its serialized form HOT 1
- Ipnetwork mismatched types HOT 2
- Add a changelog HOT 1
- Version 1.0 HOT 1
- Dependency Dashboard
- `NetworkSize` should implement `From<u32>`, `From<u128>`, `TryInto<u32>` and `Into<u128>` HOT 4
- /0 networks handled wrong
- `IpAddr` broken link
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ipnetwork.