Comments (5)
- Connection的Stop没有保证一致性,比如应用层主动调用Stop,读协程中刚好触发了Stop,两个协程在判断 c.isClosed 时都是false,后面的close chan等就会执行多次,导致panic,此处可以改成原子或者加锁
from zinx.
- func (c *Connection) StartWriter() 中最好也defer Stop, 比如客户端关闭了读,会触发写失败,写协程已经退出了,但是客户端读并没有失败,不能及时关闭异常连接,应用层可能继续给这个Connection发包,然后请看问题4
from zinx.
- Connection的SendMsg中,建议用select + default,避免chan满时导致应用层阻塞
c.msgChan <- msg //chan满时导致阻塞,比如3中的场景,应用层持续给这个连接SendMsg,满了,然后阻塞了,如果应用层是广播的逻辑后者任务池中发的这个包,其他模块就都被阻塞了,直到此连接其他情况退出时才恢复
from zinx.
只看了几分钟代码,暂时感觉以上几个地方存在问题,如果有讲的不准确的地方咱们再讨论,作者大佬看下是否需要优化、修复
from zinx.
非常感谢您的建议,我们会斟酌您的建议 修正之后合并到代码之中,如果您也想直接修复的话,也可以直接提交 Pull Request
哈。
from zinx.
Related Issues (20)
- note: "go.1.16+ //go:build comment without // +build comment" error.
- 异步问题 HOT 3
- 建议增加设置golang net的默认keepalive的方法 HOT 1
- 请教zinx必须通过msgid处理消息吗 HOT 3
- 如果在同一台服务器初始化了两个server,初始化服务器顺序不同,导致routerslice问题 HOT 1
- 请问怎么构建一个websocket的client? HOT 1
- 关闭服务时,书写重复代码 HOT 1
- RouterSlices中Handlers的意义还存在逻辑错误 HOT 1
- connection.go SendBuffMsg函数代码重复 HOT 3
- clone函数切片应该使用深拷贝 HOT 5
- Request stepLock and Chain.Proceed
- 在zinx中网关节点做转发协议该如何配置路由? HOT 3
- How to send mesaage from server to cleint? HOT 2
- 支持TLS吗? HOT 1
- windows上通信,路由的触发会存在卡顿的情况 HOT 3
- [Warnning]: Request 对象池机制问题 HOT 2
- 如果我用其他语言写一个客户端,怎么才能触发路由 HOT 3
- 怎么能设置 拨号的超时时间 HOT 1
- [Panic]: send on closed channel
- decoder、pack、framedecoder HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zinx.