Git Product home page Git Product logo

Comments (4)

abigsmall avatar abigsmall commented on June 16, 2024 1

I was confused by this too until I thought of it as the priority that’s assigned to bugs. a P1 bug would be of the “all hands on deck” type, whereas a P5 is “meh, we’ll probably never get around to it”. see here for one description of priority bug rankings.

from react-fiber-architecture.

Prinzhorn avatar Prinzhorn commented on June 16, 2024 1

I was confused by this too until I thought of it as the priority that’s assigned to bugs. a P1 bug would be of the “all hands on deck” type, whereas a P5 is “meh, we’ll probably never get around to it”. see here for one description of priority bug rankings.

@abigsmall Except for NoWork, which should be 6 following this logic ;)

from react-fiber-architecture.

mquandalle avatar mquandalle commented on June 16, 2024

This is indeed a potential confusion that we see in the current code: https://github.com/facebook/react/blob/f53854424b33692907234fe7a1f80b888fd80751/src/renderers/shared/fiber/ReactFiberScheduler.js#L427

I’m also curious about this design decision.

from react-fiber-architecture.

abigsmall avatar abigsmall commented on June 16, 2024

@Prinzhorn nah, the context of the logic is “the priority that’s assigned to bugs”. a P5 bug still has a modicum of possibility of being fixed, whereas a bug that will absolutely not be fixed will not be given any priority at all. I think that falls in line with a priority value of 0, essentially. perhaps a bit of a stretch, but it makes sense to me :)

from react-fiber-architecture.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.