Comments (5)
The PMD page on the severity levels indicates that level 1 is to be used to indicate critical broken / buggy code so it wouldn't be unusual, I think, to flag these at the error level instead of warning. In terms of a pull request, I would think we'd need to retain current behavior but add a maximum severity level that should be treated as an error - defaulted to 0.
from eclipse-pmd.
Since eclipse-pmd supports multiple rulesets, and we use this feature, a simple idea is to set the priority at the ruleset level in eclipse-pmd when adding a ruleset to eclipse-pmd.
Not everyone splits the rulesets accordingly, but hopefully this is an easy first implementation (it's "good enough" for us! :-) (we have "build fail" rules and "the rest", so the "build fail" rules need to have error priority)
from eclipse-pmd.
Any updates here? I see this hasn't been addressed in a couple years and wondering if there was any idea to move forward on this. I personally don't have the eclipse-plugin experience to do so which is why I ask.
from eclipse-pmd.
In my opinion PMD issues are warnings not errors. Errors prevent an application from working correctly, e.g. compile errors or bugs. PMD finds design issues which make the code more complicated than necessary or harder to extend in the future. Even if you do not fix the PMD issues right away your application will most likely run and work correctly.
This is my opinion of course and is the reason why I have not addressed this issue yet. However, I am not opposed to include this feature if someone were to send a pull request. Unfortunately I have very limited time to work on eclipse-pmd and this simply is not a high priority.
from eclipse-pmd.
I finally finished fixing all of the PMD warnings in a project I am working on. I would like to never merge a code change that leaves a PMD warning. Hence, I would like to have the PMD warnings be marked as errors. If a PMD warning/error shows up in a file I am editing, then I will fix the problem. If a PMD warning/error shows up in another file due to code changes in a file I am editing, then I might miss it. At least, an error will cause Eclipse to prompt me before running the project. Warnings may go unnoticed.
from eclipse-pmd.
Related Issues (20)
- An error occurred while automatically activating bundle ch.acanda.eclipse.pmd.core HOT 3
- Eclipse Neon (4.6) install through marked but nothing shows up HOT 2
- Diff to pmd/pmd-eclipse-plugin HOT 3
- Improve ruleset feedback HOT 2
- Remote ruleset: rules caching/refresh frequency? HOT 2
- Automatically update workspace relative configurations when the project name changes
- The rule set configuration at the given location is invalid HOT 9
- Eclipse PDT. Cannot change PMD nature of project <projectName> HOT 2
- New releases HOT 3
- Release 1.9 HOT 9
- XML parsing problem in Eclipse Oxygen HOT 1
- NoClassDefFoundError with version 1.12 in Eclipse Photon
- pmd can not find my enum class (configure auxclasspath) HOT 2
- eclipse-pmd 1.14 depends on pmd 6.6.0 and asm 6.1.1, but pmd 6.6.0 depends on asm 6.2 HOT 1
- Cannot use apex rules HOT 1
- Problem installing on STS 4 HOT 2
- Bug: After importing an exising project, no more PMD checks were performed HOT 2
- Bug: ruleset of other projects are also listed HOT 2
- Developer should be able to exclude violation HOT 4
- Use Rulesets with unkonwn rules (from newer PMD versions) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eclipse-pmd.