Comments (4)
vidarh
commented on August 19, 2024
This looks to be a failure of error checking in consul-skipper (retrieveNode in skipper.go sets c.node to nil in the case of a failure). I'll prepare a patch.
However even with fixing this, it seems consul going away does not trigger a notification, but I'll look into that more closely.
from consul-alerts.
vidarh
commented on August 19, 2024
I've submitted a pull request to consul-skipper to fix this upstream:
darkcrux/consul-skipper#1
from consul-alerts.
darkcrux
commented on August 19, 2024
Cool. Thank @vidarh, I'll have a look at it.
from consul-alerts.
fusiondog
commented on August 19, 2024
Looks like the upstream pull request was merged. Current behaviour on consul failing is for consul-alerts to close but it doesn't seem to crash the same way. I think that closing is probably the correct step as it is dependent. Closing pending further concern.
from consul-alerts.
Related Issues (20)
- Support parametric notification profiles HOT 2
- Disable notifications with consul tags HOT 1
- email notifier: distinct email receivers based on consul service HOT 1
- Checks status "from [empty] to passing/critical"
- docker image does not send http-notification HOT 3
- 200 is not the only code that indicates success
- Config not updating
- Change the default URL where reads the config in consul "/consul-alerts/xxx" for another URL, for example "/consul-alerts-2/xxx"? HOT 1
- INFO[0003] Running for leader election... Error querying Consul agent: Unexpected response code: 403 (Permission denied) INFO[0003] Shutting down watcher --> Exit Code: 1 HOT 1
- Support JWT auth for HTTP notifier HOT 2
- Update docker image.
- (Stale) Reminder doesnt get deleted
- consul-alerts stops working after some time
- Can't connect to https consul endpoint
- Cant download consulalerts 0.6.0 HOT 1
- version display error
- Opsgenie notifier should allow to configure different target address
- http-endpoint-notifier : Possibility to add HTTP headers ?
- 'Running for leader election' repeating
- Incorrect policy given in README HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from consul-alerts.