Git Product home page Git Product logo

Comments (10)

bcwilsondotcom avatar bcwilsondotcom commented on August 19, 2024

+1 on this. One of my concerns with moving all of my monitoring/alerting from Sensu to Consul is not easily being able to enable/disable alerting on checks.

I think both of lyrixx's options are valid scenarios. Either I have a node which I want to disable alerting on temporarily, or, I have a check script which is behaving undesirably on all nodes and I want to disable that check completely.

from consul-alerts.

hunter avatar hunter commented on August 19, 2024

Although it would add complexity, it might actually be useful to allow both a full black list and individual hosts (or even tags).

from consul-alerts.

darkcrux avatar darkcrux commented on August 19, 2024

I like both idea. We can possibly add both. The blacklist would have more weight than the individual config.

Basically, if it's blacklisted, ignore it right away. If not, check if it's enabled/disabled. Tags would probably be the most flexible (and more complex) solution.

from consul-alerts.

darkcrux avatar darkcrux commented on August 19, 2024

Hi guys, just release v0.1.2 with a blacklist feature. Config guide is in the README. Check it out. I think we've covered most use-cases with this. We can implement a tag based solution sometime soon.

from consul-alerts.

lyrixx avatar lyrixx commented on August 19, 2024

Huhu, I just noticed it in my logs

time="2014-11-14T09:59:15Z" level="info" msg="Unable to check blacklist for frontend-1.insight-d1:_:database, return false"

Thanks, I will be able to "stop" checks during deploy, and to always discard some checks ;)

from consul-alerts.

darkcrux avatar darkcrux commented on August 19, 2024

There's two reason for that message (it should have been a warning, not an info, will fix the logs). Either consul-alerts/config/checks/frontend-1.insight-d1/_/database/blacklisted does not exist, or the value is not true or false. Or maybe a typo? ;)

from consul-alerts.

lyrixx avatar lyrixx commented on August 19, 2024

Yes, the value does not exist (yet). I just noticed that when I tried to debbuging the issue with slack. ;)

from consul-alerts.

darkcrux avatar darkcrux commented on August 19, 2024

haha. yeah. Logging needs better cleanup. I'll add it to my list.

from consul-alerts.

darkcrux avatar darkcrux commented on August 19, 2024

Just release v0.2.0 with changes to how this is implemented. Fixed a possible race condition which @lyrixx pointed out. It's much simpler now.

Check out the README for more info. Cheers.

from consul-alerts.

lyrixx avatar lyrixx commented on August 19, 2024

perfect ;)

from consul-alerts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.