Git Product home page Git Product logo

Comments (10)

aisrael avatar aisrael commented on August 20, 2024

How about letting each alert daemon run continuously, and periodically run leader election using Consul itself?

http://www.consul.io/docs/guides/leader-election.html

from consul-alerts.

dpetzel avatar dpetzel commented on August 20, 2024

Oh, I like that! :)

from consul-alerts.

darkcrux avatar darkcrux commented on August 20, 2024

Interesting. The client leader election looks pretty simple and cool.

At the moment, consul-alerts is already aware of which consul node is the leader though it does nothing with that info. Quick fix, It'd just be a simple change in the logic for enabling/disabling health checks (and a new config key) to enable this feature. This solves the immediate issue at hand though we're relying on consul's leader election instead of doing our own.

I do like the idea of consul-alerts having it's own leader-election.

from consul-alerts.

lyrixx avatar lyrixx commented on August 20, 2024

I do like the idea of consul-alerts having it's own leader-election.

Me too. I think it's a simple and robust idea.

from consul-alerts.

bcwilsondotcom avatar bcwilsondotcom commented on August 20, 2024

Using consul's build in leader election is the perfect way to handle this. Definitely on the right track here.

from consul-alerts.

lyrixx avatar lyrixx commented on August 20, 2024

Hi @darkcrux

I really don't want to push you, but do you know when you could release a new version with this patch?
Because I need it and so I have to know If I should implement something on my side to work-around this issue.

Thanks.

from consul-alerts.

darkcrux avatar darkcrux commented on August 20, 2024

@lyrixx I might have some time this week to hack around this. Aiming to complete this one and the reminder feature.

from consul-alerts.

darkcrux avatar darkcrux commented on August 20, 2024

Leader elections is now in place and is done automatically. Only the leader will send out notifications. Only works for checks and not events though as we may still want to trigger events on specific nodes.

from consul-alerts.

lyrixx avatar lyrixx commented on August 20, 2024

@darkcrux Thanks for this feature ;)

Could you release a new version? thanks.

from consul-alerts.

sean- avatar sean- commented on August 20, 2024

A new version has been released... can we close this issue?

from consul-alerts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.