Comments (7)
mvukov
commented on June 24, 2024
This is already in the compiler flags, look at cmake/CompilerOptions.cmake. OK, will add -Wextra :)
from acado.
ghorn
commented on June 24, 2024
Right now I'm seeing these warnings:
acado/src/utils/acado_string.cpp: In constructor ‘ACADO::String::String(const double&)’:
acado/src/utils/acado_string.cpp:69:15: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
acado/src/matrix_vector/matrix.cpp: In member function ‘ACADO::Vector ACADO::Matrix::getEigenvalues(ACADO::Matrix&) const’:
acado/src/matrix_vector/matrix.cpp:672:22: warning: variable ‘cos_2phi’ set but not used [-Wunused-but-set-variable]
acado/src/user_interaction/plot_window.cpp: In member function ‘ACADO::returnValue ACADO::PlotWindow::setupLogFrequency(ACADO::PlotFrequency)’:
acado/src/user_interaction/plot_window.cpp:734:15: warning: variable ‘logFrequency’ set but not used [-Wunused-but-set-variable]
acado/src/sparse_solver/normal_conjugate_gradient_method.cpp: In member function ‘virtual ACADO::returnValue ACADO::NormalConjugateGradientMethod::setIndices(const int*)’:
acado/src/sparse_solver/normal_conjugate_gradient_method.cpp:141:9: warning: variable ‘bound2’ set but not used [-Wunused-but-set-variable]
acado/src/code_generation/model_data.cpp: In member function ‘std::vector<ACADO::Matrix> ACADO::ModelData::getOutputDependencies() const’:
acado/src/code_generation/model_data.cpp:178:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
acado/src/code_generation/model_data.cpp:184:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
acado/src/code_generation/model_data.cpp: In member function ‘ACADO::Vector ACADO::ModelData::getDimOutputs() const’:
acado/src/code_generation/model_data.cpp:490:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
acado/src/code_generation/model_data.cpp: In member function ‘ACADO::Vector ACADO::ModelData::getNumMeas() const’:
acado/src/code_generation/model_data.cpp:513:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
acado/src/code_generation/condensing_export.cpp: In member function ‘ACADO::returnValue ACADO::CondensingExport::setupMultiplicationRoutines()’:
acado/src/code_generation/condensing_export.cpp:549:20: warning: declaration of ‘Gx’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:550:20: warning: declaration of ‘Gu’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:555:20: warning: declaration of ‘C’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:556:20: warning: declaration of ‘QC’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:557:20: warning: declaration of ‘E’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:558:20: warning: declaration of ‘QE’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:559:20: warning: declaration of ‘QDx’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:560:20: warning: declaration of ‘g0’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:561:20: warning: declaration of ‘g1’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:562:20: warning: declaration of ‘H00’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:563:20: warning: declaration of ‘H01’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/condensing_export.cpp:564:20: warning: declaration of ‘H11’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/sim_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::SIMexport::exportCode(const ACADO::String&, const ACADO::String&, const ACADO::String&, int)’:
acado/src/code_generation/sim_export.cpp:161:6: warning: declaration of ‘exportTest’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/sim_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::SIMexport::exportAndRun(const ACADO::String&, const ACADO::String&, const ACADO::String&, const ACADO::String&, const ACADO::String&)’:
acado/src/code_generation/sim_export.cpp:743:6: warning: variable ‘nil’ set but not used [-Wunused-but-set-variable]
acado/src/code_generation/sim_export.cpp: In member function ‘ACADO::returnValue ACADO::SIMexport::executeTest(const ACADO::String&)’:
acado/src/code_generation/sim_export.cpp:1022:6: warning: variable ‘nil’ set but not used [-Wunused-but-set-variable]
acado/src/code_generation/integrators/erk_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::ExplicitRungeKuttaExport::setLinearOutput(const ACADO::Matrix&, const ACADO::Matrix&, const ACADO::Expression&)’:
acado/src/code_generation/integrators/erk_export.cpp:256:114: warning: declaration of ‘rhs’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/integrators/erk_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::ExplicitRungeKuttaExport::setupOutput(std::vector<ACADO::Grid>, std::vector<ACADO::Expression>)’:
acado/src/code_generation/integrators/erk_export.cpp:341:124: warning: declaration of ‘rhs’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/integrators/narx_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::NARXExport::setLinearOutput(const ACADO::Matrix&, const ACADO::Matrix&, const ACADO::Expression&)’:
acado/src/code_generation/integrators/narx_export.cpp:268:100: warning: declaration of ‘rhs’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/integrators/narx_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::NARXExport::setupOutput(std::vector<ACADO::Grid>, std::vector<ACADO::Expression>)’:
acado/src/code_generation/integrators/narx_export.cpp:343:110: warning: declaration of ‘rhs’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/integrators/irk_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::ImplicitRungeKuttaExport::setLinearOutput(const ACADO::Matrix&, const ACADO::Matrix&, const ACADO::Expression&)’:
acado/src/code_generation/integrators/irk_export.cpp:150:114: warning: declaration of ‘rhs’ shadows a member of 'this' [-Wshadow]
acado/src/code_generation/integrators/irk_export.cpp:178:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
acado/src/code_generation/integrators/irk_export.cpp: In member function ‘ACADO::returnValue ACADO::ImplicitRungeKuttaExport::generateOutput(ACADO::ExportStatementBlock*, const ACADO::ExportIndex&, const ACADO::ExportIndex&, const ACADO::ExportIndex&, const ACADO::ExportIndex&, const ACADO::ExportVariable&, const ACADO::ExportVariable&, const ACADO::ExportVariable&)’:
acado/src/code_generation/integrators/irk_export.cpp:1671:37: warning: comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning [-Wparentheses]
acado/src/code_generation/linear_solvers/householder_qr_export.cpp: In member function ‘virtual ACADO::returnValue ACADO::ExportHouseholderQR::setup()’:
acado/src/code_generation/linear_solvers/householder_qr_export.cpp:276:15: warning: variable ‘structWspace’ set but not used [-Wunused-but-set-variable]
from acado.
ghorn
commented on June 24, 2024
there are more in qp oases, csparse, and gnuplot, but i think we can ignore those
from acado.
ghorn
commented on June 24, 2024
@rienq could you look at the ones in integrators and sim_export please?
from acado.
mvukov
commented on June 24, 2024
We achieved "clean" compilation with -Wall flags. -Wextra is still producing a lot of warnings, and btw this flag is not used.
You can monitor builds here: https://travis-ci.org/acado/acado
from acado.
rienq
commented on June 24, 2024
awesome ! :-)
from acado.
mvukov
commented on June 24, 2024
OK, this seems to be finalized....
from acado.
Related Issues (20)
- Obstacle as time varying constrains
- S-Function through legacy Code Generation in Matlab
- When will there be a stable version?
- error: no rule to make target 'qpdunes/src/utils.o', needed by 'libacado_exported_rti.a'
- Timed solver interruption
- Autogenerated MPC Code segfaults in acado_feedbackStep( ) on large OCP definitions HOT 1
- Problem with IntermediateStates
- Slicing Matrices and Vectors in ACADO matrix class
- Installation in Mac OS HOT 2
- Inquires on ACADO with MATLAB and SIMULINK for the single-precision microcontroller
- MPC with on/off value HOT 1
- unable to interface with MATLAB HOT 2
- Setting LSQ reference in ACADO code, getting error
- what is the status of acado tookit?
- Trouble getting started HOT 1
- Constraint violation with Time-Scaled model
- how to improve the accuracy of the generated NMPC solver
- Unable to understand 'Shifting' and 'initialization' option in ACADO MPC simulink interface
- can you anybody explain what is online data ?
- Code generation template path stays persistent between builds
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from acado.