make code PEP8 compliant about rez HOT 2 CLOSED

RE whitespace, sure go ahead.

You're right also about the rez_ prefix to a lot of the modules, this is a
hangover from before code was structured into a package.

thx
A

On Wed, Nov 27, 2013 at 6:06 PM, Chad Dombrova [email protected]:

I would love to see the rez codebase made more PEP8 compliant:
http://www.python.org/dev/peps/pep-0008/

current problems:

• some files use tabs instead of space tabs
• use of type(foo) == type(bar) instead of isinstance
• use of g_variable for global constants ( prefix denotes private
  variables)
• general whitespace issues like foo=3 instead of foo = 3 and foo(1+2)instead of foo(1
  +2)
• importing all: from module import *
• importing modules from inside a package without the module prefix:
  e.g. import rez_config instead of import rez.rez_config.

non-pep8 style issues:

• the rez_ prefix in front of some of the modules is redundant and
  non-standard. I get the impression that rez used to be a bunch of separate
  modules that were not under a package, but now that it is a package,
  there's no longer a need for the prefix.

now is the time to fix these things since the code is in such flux that
other changes are highly unlikely to merge anyway.

If you give me the go ahead, I can automatically fix all whitespace issues
with autopep8. I use these settings:

autopep8 -i -r -v --pep8-passes=300 --ignore=E501,E302

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/43
.

from rez.

This is really close, but I would like to do 2 things before we close:

• document in the README about setting up pep8 warnings in eclipse and sublime
• run autopep8 one more time after the current outstanding merges

from rez.