Failure to detect the distribution and the distribution version when running on a Mac about rez HOT 3 CLOSED

Cheers Benjamin, although I'd expect the distro to be identified as Darwin?

Also, can you provide these fixes as pull requests at all?

Cheers
A

On Thursday, August 15, 2013, bsergean wrote:

I'm getting errors when I'm running configure.sh, I've fixed it so I get
some relevant info on a Mac. This is what with the fix:

detecting OS distribution...
OS distribution is: Apple

detecting OS distribution version...
OS distribution version is: 10.8.3

Patch:

diff --git a/configure.sh b/configure.sh
index 29d2148..c6f2e6c 100755
--- a/configure.sh
+++ b/configure.sh
@@ -246,6 +246,9 @@ if [ "$distro" == "" ]; then
distro=lsb_release -i | awk '{print $NF}'
if [ $? -ne 0 ]; then distro=; fi
fi

• if [ "$osname" == "Darwin" ]; then

•    distro=Apple
  

• fi
  if [ "$distro" == "" ]; then
  echo $echoerr"Could not identify OS distribution - $or_set""REZCONFIG_DISTRO" 1>&2
  echo "Setting to DISTRO_UNKNOWN-0!"$echoreset 1>&2
  @@ -263,6 +266,10 @@ if [ "$distro_version" == "" ]; then
  distro_version=lsb_release -r | awk '{print $NF}'
  if [ $? -ne 0 ]; then distro_version=; fi
  fi
• if [ "$osname" == "Darwin" ]; then

•    distro_version=`sw_vers -productVersion`
  

•    if [ $? -ne 0 ]; then distro_version=; fi
  

• fi
  if [ "$distro_version" == "" ]; then
  echo $echoerr"Could not identify OS distribution version - $or_set""REZCONFIG_DISTRO_VERSION" 1>&2
  echo "Setting to 0!"$echoreset 1>&2

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/25
.

from rez.

I would say that the OS is Darwin, and the vendor is Apple, that's why I
went with Distribution = Apple.
But hey, I just made this up, so Darwin is probably good as well, I don't
mind too much :)
MacOSX is probably a good option too.

I played with git a long time ago so I have to refresh my memory on
creating pull request, I looked that
up online but I haven't tried to hard.

Cheers,

• Benjamin
• Benjamin

On Wed, Aug 14, 2013 at 5:04 PM, allan johns [email protected]:

Cheers Benjamin, although I'd expect the distro to be identified as
Darwin?

Also, can you provide these fixes as pull requests at all?

Cheers
A

On Thursday, August 15, 2013, bsergean wrote:

I'm getting errors when I'm running configure.sh, I've fixed it so I get
some relevant info on a Mac. This is what with the fix:

detecting OS distribution...
OS distribution is: Apple

detecting OS distribution version...
OS distribution version is: 10.8.3

Patch:

diff --git a/configure.sh b/configure.sh
index 29d2148..c6f2e6c 100755
--- a/configure.sh
+++ b/configure.sh
@@ -246,6 +246,9 @@ if [ "$distro" == "" ]; then
distro=lsb_release -i | awk '{print $NF}'
if [ $? -ne 0 ]; then distro=; fi
fi

• if [ "$osname" == "Darwin" ]; then
• distro=Apple
• fi
  if [ "$distro" == "" ]; then
  echo $echoerr"Could not identify OS distribution -
  $or_set""REZCONFIG_DISTRO" 1>&2
  echo "Setting to DISTRO_UNKNOWN-0!"$echoreset 1>&2
  @@ -263,6 +266,10 @@ if [ "$distro_version" == "" ]; then
  distro_version=lsb_release -r | awk '{print $NF}'
  if [ $? -ne 0 ]; then distro_version=; fi
  fi
• if [ "$osname" == "Darwin" ]; then
• distro_version=sw_vers -productVersion
• if [ $? -ne 0 ]; then distro_version=; fi
• fi
  if [ "$distro_version" == "" ]; then
  echo $echoerr"Could not identify OS distribution version -
  $or_set""REZCONFIG_DISTRO_VERSION" 1>&2
  echo "Setting to 0!"$echoreset 1>&2

—
Reply to this email directly or view it on GitHub<
https://github.com/nerdvegas/rez/issues/25>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-22676876
.

from rez.

Works nicely in the osx branch, closing.

from rez.