Git Product home page Git Product logo

Comments (6)

joelnet avatar joelnet commented on June 10, 2024 1

@joelnet do you think that is better to return array ?

const [value, success] = await kinka.get('/donuts')

I think that it is not a good idea because what if I want to get only properties data and err ? Using array desctructing have order of destruct

Probably not. Seemed interesting at first, but it would be restrictive in which args you send back and which order you send them back in. For example, if you update your app and remove something from index 1, you would break everyones code. With object destructuring, you wouldn't have to worry about it. Ignore my initial comment about the Array.

from kinka.

js2me avatar js2me commented on June 10, 2024 1

@joelnet yeah! Thanks for your feedback!
Next release will have this changes

from kinka.

js2me avatar js2me commented on June 10, 2024

@joelnet do you think that is better to return array ?

const [value, success] = await kinka.get('/donuts')

I think that it is not a good idea because what if I want to get only properties data and err ? Using array desctructing have order of destruct

from kinka.

js2me avatar js2me commented on June 10, 2024

@joelnet I want to hear your opinion about properties of the response object
Currently I did properties

   const { status, data , err, isError, isSuccess } = await kinka.get('/donuts')

What do you thing about these property names?
or better rename err to errorMessage or something else

from kinka.

joelnet avatar joelnet commented on June 10, 2024

I like those! I wouldn't use isError or isSuccess, I would just test the err object. But some people might find these useful so they could be beneficial to leave in. With destructuring, they could get what info they want.

from kinka.

js2me avatar js2me commented on June 10, 2024

solved in 0.0.40--alpha

from kinka.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.