Git Product home page Git Product logo

Comments (8)

mottosso avatar mottosso commented on August 11, 2024

I'm thinking a context-manager to automatically reset the time after each capture would be good here. No command should really mess with state, unless it's intended to.

from maya-capture.

BigRoy avatar BigRoy commented on August 11, 2024

I'm thinking a context-manager to automatically reset the time after each capture would be good here. No command should really mess with state, unless it's intended to.

That's a separate issue, since that's unrelated to the undo bug of the playblast command? Also that would mean setting the time afterwards instead of beforehand?

But yes, I totally agree. Set up the issue and I'll implement.

from maya-capture.

mottosso avatar mottosso commented on August 11, 2024

But wouldn't that nullify this problem? If capture never altered the frame to begin with?

from maya-capture.

mottosso avatar mottosso commented on August 11, 2024

Would it still revert to frame 1 you think? :O

from maya-capture.

BigRoy avatar BigRoy commented on August 11, 2024

Would it still revert to frame 1 you think? :O

I think so, yes. But I'm thinking in the form of "undo chain". The current time is set afterwards thus gets processed first when undo'ing. Since the playblast has the issue where it resets to frame 1 on undo, the issue would then still be present.

But I'll have a look!

from maya-capture.

BigRoy avatar BigRoy commented on August 11, 2024

Yup, as I thought, the issue would still be there. :(
So setting in front and include a context manager would fix both.

But wouldn't that nullify this problem? If capture never altered the frame to begin with?

The issue with undoing is even there when you use the cmds.playblast command solely to list the available compressions instead of actually performing a capture/playblast. It's a real bug. It doesn't actually have anything to do with altering the time.

from maya-capture.

BigRoy avatar BigRoy commented on August 11, 2024

This is fixed with BigRoy@f4a2207.

I'm thinking a context-manager to automatically reset the time after each capture would be good here. No command should really mess with state, unless it's intended to.

See #23.

from maya-capture.

mottosso avatar mottosso commented on August 11, 2024

Aweseome!

from maya-capture.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.