Git Product home page Git Product logo

Comments (9)

poutnikl avatar poutnikl commented on May 29, 2024

Still not fixed - another Brouter user hit this, mentioning it on the forum.

from brouter.

utack avatar utack commented on May 29, 2024

@abrensch we all know you are doing amazing work in your free time, and can do whatever you want at any time schedule, but could you maybe mention if you have these kind of things on your radar, or expect pull requests from the community, so we know what the status is?
Thank you!

from brouter.

VA00 avatar VA00 commented on May 29, 2024

Similar issue, proposed route via highway=construction, impassable.

image

from brouter.

poutnikl avatar poutnikl commented on May 29, 2024

Until @abrensch fixes the standard profiles, you may as a workaround use custom profiles, e.g. from Github repositiories of utack or poutnikl.

from brouter.

Phyks avatar Phyks commented on May 29, 2024

Discussed in https://groups.google.com/d/msgid/osm-android-bikerouting/19b79f1b-fe71-4f07-bfc5-945323493b7b%40googlegroups.com as well.

from brouter.

Phyks avatar Phyks commented on May 29, 2024

From #208

Maybe BRouter should take into acount the value of the construction= tag to decide whether to route on it or not. I would expect that pedestrian (and bicycles) can pass on a highway=construction + construction=primary|secondary|tertiary|residential (main traffic being cars, side traffic can be maintained) but I would not expect that they could pass on a highway=construction + construction=cycleway|footway|path (main traffic is pedestrian / cycles) for instance.

from brouter.

stefanct avatar stefanct commented on May 29, 2024

I don't agree with Phyks. The view of pedestrians and cyclists being just "side traffic" (even on "residential" roads(!)) is a distorted and devastating car-centric view that has plagued city planning for decades. Let's not repeat that in OSM please. Unless there is an explicit =yes (or similar), any way under construction should be deemed as non-existent. While it is a bit vaguely phrased, I deem the current wiki specification "impassable by the traffic it is intended for." quite clear - especially in this context: if a street is not intended for some traffic brouter does not route it via the non-construction variants either. So by definition one deduce that a way under construction should not be part of the routing network.

I fell for this issue as well in the case of a highway=construction, construction=cycleway just yesterday. And even worse, I tried to mitigate it/refine the tagging by adding a conditional access tag for the expected duration of the construction works... and fell for the next issue: conditionals are not supported either (#193, #300).

I get that conditionals are not trivial to support (not even the syntax is completely specified in some corner cases :) but highway=construction would be easy to just ignore and while there are some regressions (for construction sites where some mode of transport actually can pass), I believe it is must more user friendly to send them on a detour unnecessarily from the beginning than to present them a bad surprise in the field.
This is easily accomplished by adding else if ( highway=construction ) then 10000 to the profile where motorways are excluded (but there might be better ways to do it to allow for highway=construction, …, bicycle=yes for example.

from brouter.

abrensch avatar abrensch commented on May 29, 2024

while there are some regressions (for construction sites where some
mode of transport actually can pass), I believe it is much more user
friendly to send them on a detour unnecessarily from the beginning
than to present them a bad surprise in the field.

Because such a single argument is hard to defeat, I would like to remind many other sloppinesses that, together, make up the "optimistic approach" of the "trekking" profile:

  • a way with a bike route relation is always passable (even with access=no)
  • oneway are allowed in wrong direction
  • foot-ways are allowed
  • turn-restrictions are ignored
  • highway=path/track with no other detail allowd
  • access=agricultural allowed

I think, if you get too restrictive, there is a tipping point where the "backbone" of your network collapses. And that leads not just to detours, bad "bad detours with bad surprises"

Construction is just one of these sloppinesses. I agree excluding construction by default for ways not intended for 2-lane vehicles is a good idea. Furthermore, every mapper is free to use access tagging to provide further details.

from brouter.

stefanct avatar stefanct commented on May 29, 2024

lol, so even if i would have added a plain access=no in that case because conditionals are not understood, it would have failed me (I think), because in this case there was a route relation that was not changed (and it should not be anyway imho: if there are no official detour signposts for the respective route then it officially goes there but you can't use it). so in total three brouter exceptions worked against me - and i don't think the way in question is in any way special... just a cycleway that is closed for a while due to renovation. i dont even know how i could map this without brouter routing over it apart from removing the way altogether or destroying the relation.

i totally agree with the idea behind the other rules you mentioned: the related tags specify legal rules but in the case of a construction site, physics is most often your biggest problem, sometimes even (lack of) safety. i definitely don't see that in the same category as using an underspecified "path" or ignoring a oneway sign.
the usefulness of the routing rules obviously depends on the quality of the data, but i think in the current implementation more detailed data means worse results and that's really bad for both projects imho (mappers who care about brouter would need to break or at least bend osm rules to make brouter work correctly and brouter users get worse routes in areas where this is not done).

from brouter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.