Provide authentication through an AuthenticationProvider interface about go-travis HOT 6 CLOSED

Implementation Idea:

interface

type AuthenticationProvider interface {
    Authenticate() (AccessToken, error)
}

usage

travis.NewClient(TRAVIS_API_DEFAULT_URL, GithubAuthProvider("mytoken"))
// or
travis.NewClient(TRAVIS_API_DEFAULT_URL, TravisAuthProvider())

from go-travis.

A possible implementation of it would consist in the following:

interface implementation

type GithubAuthProvider struct {
        GithubToken string
}

type TravisAuthProvider struct {
        TravisToken string
}

func (*GithubAuthProvider) Authenticate() (AccessToken, error) {
    // get and return a travis token from the api using the github token 
}

func (*TravisAuthProvider) Authenticate() (AccessToken, error) {
    // return the TravisToken
}

client implementation

func (c *Client) Authenticate(auth AuthenticationProvider) error {
    c.client.Headers["Authorization"] = "token " + auth.Authenticate()
}

from go-travis.

Spotted a problem in the implementation of this design: the GithubAuthProvider would need the client instance to query travis for a travis token. Which would actually lead to an impossible design as the client constructor would need to pass himself to the provider.

# Not possible
client := NewClient(TRAVIS_API_DEFAULT_URL, GithubAuthProvider(clientIHaventBuiltJustYet, token))

from go-travis.

A workaround could be to add a client attribute to the provider when relevant. To pass the provider to the constructor with its client attribute uninitialized. And when calling Client.Authenticate initializing the provider client attribute, and calling its Authenticate method.

func (c *Client) Authenticate(auth AuthenticationProvider) error {
    auth.client = c.client
    c.client.Headers["Authorization"] = "token " + auth.Authenticate()
}

But this sounds super hacky, and introduces mutability, which was exactly the aspect of current implementation we are trying to get rid of.

from go-travis.

Hey @tcr-ableton, do you think it would make sense to close this?

from go-travis.

Given the state of things, I don't think this issue will be addressed anytime soon.

from go-travis.